React-starter-kit: Unneeded Deps

Created on 27 Aug 2016  路  4Comments  路  Source: kriasoft/react-starter-kit

I'm thinking if bluebird is really necesary since node >= 5 has built-in ES6 promises.

Can I try to remove bluebird and make PR? I just want to help have a slightly cleaner code.

Also core-js is necesary?

discussion

Most helpful comment

bluebird is well tested and optimized Promise implementation. I'm for keeping it

All 4 comments

core-js is not directly referenced, but listed as dependency of other packages. Should probably be removed from package.json. bluebird is being used, but can easily be extracted.

bluebird is well tested and optimized Promise implementation. I'm for keeping it

bluebird is faster than the "native" promise implementation and on the browser side you lose compatibility with all IEs and a bunch of older browsers (see http://caniuse.com/#feat=promises )

Amazing! So, is it preferable to set as default promises?

require('babel-runtime/core-js/promise').default = require('bluebird');

Was this page helpful?
0 / 5 - 0 ratings