React-starter-kit: Convert from react-routing to react-router

[thehashrocket]

Has anyone done this recently? I see that around Sept of 2014 it switched from director to react-router and now it's on react-routing. There doesn't seem to be a lot of documentation around that, furthermore, most people seem to be using react-router instead.

Is anyone else in the same boat I am? I'd rather use something that has a bit more community around it if possible.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[dfejgelis]

+1. Same concern here.
So far reat-routing has been working ok for me, but I'm thinking on refactor to react-router every time I need something and cannot find any doc.

[yidongnan]

+1

[jerez]

+1

[ziogaschr]

+1

[audi70r]

+1

[leonprou]

@koistya, react-router will be supported soon?
I wonder about the ready tag

[wstoettinger]

+1

[willwnekowicz]

+1. react-router appears to be a much more mature project

[putudondo]

+1

[koistya]

@leonprou ready means that it's on a to-do list (what's coming next).

Have anybody tried replacing the routing information inside the src/routes.js file with routes in RR format + modify the server-side rendering logic in src/server.js (here)? Maybe you can share your fork with work-in progress and we can collaboratively fix the remaining issues for that integration if any.

[kwelch]

I haven't started on it but I had plans on looking into this week. I was looking at going the same direction you mentioned.

[kwelch]

I started to look into this, but I wanted to share this incase someone else attempts to pick this up.
I believe the lazy routes will be a better win for this project.

https://medium.com/@ryanflorence/welcome-to-future-of-web-application-delivery-9750b7564d9f#.ibtn2fxh3

[Bogdaan]

@kwelch +1 lazy routes is awesome, but i have no idea how to use them with altjs or flux

[kwelch]

Agreed. It has slowed my ability to wrap this convert up.

[MathieuCh]

+1 react-router

[hamzazar]

+1

[okendoken]

+1

[okendoken]

@kwelch did you start to work on that? I could try to handle it too.

[kwelch]

I did but haven't gotten far enough for someone to leverage it. Feel free
to start tackling it.

On Sat, Jan 16, 2016, 10:46 AM Philip Daineka [email protected]
wrote:

@kwelch https://github.com/kwelch did you start work on that? I could
try to handle it too.

—
Reply to this email directly or view it on GitHub
https://github.com/kriasoft/react-starter-kit/issues/345#issuecomment-172226045
.

[okendoken]

Cool! Thanks for response, Then I'll provide a fork for review in next days.

Philip Daineka,
flatlogic.com

On Sun, Jan 17, 2016 at 4:17 PM, Kyle Welch [email protected]
wrote:

I did but haven't gotten far enough for someone to leverage it. Feel free
to start tackling it.

On Sat, Jan 16, 2016, 10:46 AM Philip Daineka [email protected]
wrote:

@kwelch https://github.com/kwelch did you start work on that? I could
try to handle it too.

—
Reply to this email directly or view it on GitHub
<
https://github.com/kriasoft/react-starter-kit/issues/345#issuecomment-172226045

.

—
Reply to this email directly or view it on GitHub
https://github.com/kriasoft/react-starter-kit/issues/345#issuecomment-172324998
.

[okendoken]

Hi everyone,

I have just finished with the basic integration of react-router. PR is not ready yet as the code is still in progress https://github.com/flatlogic/react-starter-kit/commit/c31ab4f1e59271eea7ea9a41ead8f1cb5653f79d.

Open questions:

1. Passing context to components https://github.com/flatlogic/react-starter-kit/commit/c31ab4f1e59271eea7ea9a41ead8f1cb5653f79d#diff-e6a5b42b2f7a26c840607370aed5301aR43. Better way than class variables?
2. Server- and client-side markup difference:

Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
(client) <noscript data-reacti
(server) <div data-reactid=".s

This seems to be connected with react/react-router lifecycles; react checks for markup consistence before react-router markup is ready

1. Preserving the scroll position. This is one is simple.

Any feedback appreciated

[puradox]

+1

[raigudakesa]

+1

[nphi]

+1

[FakhruddinAbdi]

+1

[virusvn]

+1

[learntoswim]

+1

[leonardoelias]

+1

[anaibol]

:D

[PetrochukM]

+1

[langpavel]

I'm sorry to all of you. This is very old issue. We have universal router now. Can anyone create pull request with React-router? I promise I will maintain it as feature for some time, then we can create some comparison of pros and cons against universal-router.

[djpark]

@langpavel / @koistya - Not sure why this issue was closed but just submitted a PR that integrates react-router with this starter kit. Look forward to hearing your thoughts.