React-slick: React v16 support

[stefensuhat]

warning "[email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.1".
warning "[email protected]" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.1".

Thanks

[teux]

Warning: getDefaultProps is only used on classic React.createClass definitions. Use a static property named defaultProps instead.

[pencilcheck]

getting weird error like Error in ./ReactMount Module not found: Error: Can't resolve 'react/lib/React' in '/project/node_modules/react-slick/node_modules/react-dom/lib'

[jonricaurte]

mixins are no longer supported:

https://github.com/akiran/react-slick/blob/master/src/inner-slider.js#L17

also should migrate away from createReactClass:

https://github.com/akiran/react-slick/blob/master/src/inner-slider.js#L16

[danjumamilhaus]

@akiran
When installing from npm, the version is "version": "0.15.4" but the peerDependancies in the package.json don't list React\ReactDOM 16:

"peerDependencies": {
    "react": "^0.14.0 || ^15.0.1",
    "react-dom": "^0.14.0 || ^15.0.1"
  },

The package.json looks like the one from the enisbaruh-master branch, not the master branch.

[screendriver]

That's what this issue is about here.

[ankitduseja]

@akiran Any idea when it will be updated on npm?

[tony99nyr]

@akiran ping. Please run a npm version patch && npm publish

[tony99nyr]

Tried to do the publish myself without success :frowning_face:

npm ERR! You do not have permission to publish "react-slick". Are you logged in as the correct user? : react-slick

[hdwatts]

Bump! Any update on this?

[superbiche]

I've made a fork by necessity, to use React 16 in our next release.
A quick and dirty fork, but at least my sliders work and I have no error.

Tests are broken as enzyme isn't compatible with React 16 yet

It's available here: https://github.com/mygooder/react-slick (use the react-16-compat branch for now).
Also published on npm: npm i @mygooder/react-slick --save

Let me know if this helps someone and eventually if we should start contributing this fork (as the original project seems still), so I publish it unscoped and update the README. We're using it in production today and we won't be switching soon.

[savbace]

@superbiche enzyme works with React 16 though require some efforts.

[superbiche]

@savbace you're right! I'm adding this to my todo. Thanks for the link.

[akiran]

Made a new release with react 16 dependency support.
Can you test it

[dschinkel]

@akiran can this below be merged into a fork and then soon a new react-slick release, we had to use this fix from @superbiche which did resolve an error and now react-slick seems to work ok in react 16 and we have to add a hack to our package.json until this is merged into the official release

"react-slick": "git://github.com/mygooder/react-slick"

would like to get rid of that.

Why would this issue be closed if it's still an issue / not resolved with a release? shouldn't this issue stay open until you get @superbiche's fix into a release?

[superbiche]

@akiran I confirm this is working in production with React 16. Many thanks !

For people using my fork, I strongly advice you to switch back to the original repo. We currently have no other plans than contributing here, so I guess this repo will move much more often than my fork.

@akiran are you looking for co-maintainers? Let me know if you do.
Best 💋