React-select: Orderable multi values

Created on 16 May 2019  路  14Comments  路  Source: JedWatson/react-select

I have managed to get a working POC of orderable multiselect on 'react-dnd' mentioned here: JedWatson/react-select#91, if someone is still interested.
orderable
If you would be interested, I would try to improve it and contribute here, or make a package out of it. Now it is bit messy, but if you guys would be able to help me a bit by reviews here: theforeman/foreman#6762, it sure can get better :slightly_smiling_face:

issuenhancement issuneeds-review

Most helpful comment

Thanks @gfortaine !!

All 14 comments

This is awesome! This is just what I needed, and I'm already using react-dnd in my app. Thanks for working on this!

@ndbroadbent and would you prefer it as a separate npm package? I have rolled with an typeahead implementation instead in the end, but I have the implementation for react-select ready and I could publish it, unfortunately I will not be able to maintain it too actively

@ezr-ondrej Oh I see, I think I could just switch to the react-bootstrap-typeahead package if that works better. Your OrderableSelect component looks great, and I'm already using react-dnd in my app.

I think this might be a good PR for react-select, but the react-dnd dependency would be quite heavy if people aren't using the feature. So maybe this could be an optional dependency.

well I will manage the implementation for the react-bootstrap-typeahead so if there are going to be other users, I will extract it from theforeman/foreman to separate repo (npm).

Yeah that was exactly my thoughts and as long as I won't use that, I don't want to drive the discussions where to put it, but if there is an idea how it should be done and someone to take care of it, I will provide the first implementation and help to clean it up.

@ezr-ondrej I'd love to have a separate package for react-select! Thank you!

Hey @ezr-ondrej, this is awesome, thanks for the contribution.

As mentioned, this would be a great package to have, let me know if you are still willing and have time to do this!

@bladey well I'd love to do so, altough some guidance from any maintainer would be nice.
For starters, I've extracted the code to https://github.com/ezr-ondrej/react-select-draggable but there's much more to do and I'd use help.

Thanks for replying @ezr-ondrej, noted - let me flag this with the maintainers before you go any further.

@ezr-ondrej It seems that we have made a pull request to build your package 馃憤 : https://github.com/ezr-ondrej/react-select-draggable/pull/1

Thanks @gfortaine !!

Marking this as closed and completed. Thank you both @ezr-ondrej and @gfortaine ! 馃檹
https://react-select.com/advanced

Awesome work @gfortaine ! Feel free to remove the fork and mark yours as the primary repo, or is there Organization for react select?

@ezr-ondrej I can get back to you about this. I have some ideas that I want to vet out with some of the others about how we can give better visibility to add-ons/HOC's like yours.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pablote picture pablote  路  3Comments

geraldfullam picture geraldfullam  路  3Comments

x-yuri picture x-yuri  路  3Comments

pashap picture pashap  路  3Comments

joshualimpj picture joshualimpj  路  3Comments