React-select: transpilation bug

Created on 21 Nov 2017  Â·  4Comments  Â·  Source: JedWatson/react-select

This code https://github.com/JedWatson/react-select/blob/master/src/Select.js#L1075
seems to get incorrectly translated to:
https://github.com/JedWatson/react-select/blob/master/dist/react-select.es.js#L1736 (why the extra !this.props.multi ? part?)

This leads to errors when trying to implement renderMenu. I.e. params.valueArray will be null.

Most helpful comment

This should be solved now

edit haha, posted this comment in a tab I've had open since yesterday, when the page refreshed @fedde-s I saw you've beaten me to it :)

All 4 comments

The ‘correct’ version of the code was introduced in pull request #1850, which was merged on 25 October. The last release was on 13 September… I think we'll have to wait for @JedWatson to push a new minor release to npm?

Looks like release v1.0.0 solves this! I can't seem to close the issue for you though.

As the hyperlinks in the original issue description referenced a mutable branch instead of a commit or tag, they point to different code now.

This should be solved now

edit haha, posted this comment in a tab I've had open since yesterday, when the page refreshed @fedde-s I saw you've beaten me to it :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

coder-guy22296 picture coder-guy22296  Â·  3Comments

batusai513 picture batusai513  Â·  3Comments

pablote picture pablote  Â·  3Comments

steida picture steida  Â·  3Comments

juliensnz picture juliensnz  Â·  3Comments