react-router-redux throws warnings with react 15.5

Created on 8 Apr 2017 · 13Comments · Source: ReactTraining/react-router

Version

react-router 3.0.3
react-router-redux 4.0.8

Issue

The changes in react 15.5 regarding PropTypes and createClass make react-router-redux throw two warnings.

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Warning: RouterContext: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Will this issue be solved or is it something that will be addressed when react-router-redux 5 is released with support for react-router 4?

Source

ricardojoaoreis

👍26

Most helpful comment

Yep, we do. I will take care of it now, though. It's not that hard to go through, luckily.

timdorr on 9 Apr 2017

🎉9

All 13 comments

Sorry to nit, but these warnings do not stem from react-router-redux (current version living here), they are all from the v3 code base of react-router.

simonkberg on 9 Apr 2017

Should be fixed on master. I'll see about getting a release out soon.

timdorr on 9 Apr 2017

@timdorr this issue is regarding RR3 (which also uses the now deprecated createClass call).

If you accept PR's for the v3 branch I'd be happy to contribute.

simonkberg on 9 Apr 2017

Yep, we do. I will take care of it now, though. It's not that hard to go through, luckily.

timdorr on 9 Apr 2017

🎉9

@simonkberg I noticed that the error was due to the react-router version that's why I mentioned it in the report 😉

@timdorr thanks for the speedy response and fix 👍

ricardojoaoreis on 9 Apr 2017

@timdorr I met the same warning with [email protected], so whether you fixing it in 2.x version?

pinggod on 11 Apr 2017

No, we're not maintaining the 2.x versions. Upgrade to 3.x, it's just 2.x without the deprecation warnings.

timdorr on 11 Apr 2017

Is this change still waiting to get into the v3 branch?

FoxxMD on 18 Apr 2017

@FoxxMD the fixes has been released https://github.com/ReactTraining/react-router/releases/tag/v3.0.4

simonkberg on 18 Apr 2017

👍2

@simonkberg thanks! I didn't see it on the release page but I didn't scroll down far enough :)

FoxxMD on 18 Apr 2017

@simonkberg I upgraded to 3.0.4 and am still seeing these warnings.

kevinguard on 22 May 2017

@kevinguard are you sure they're coming from RR? could you post the full stack trace?

simonkberg on 22 May 2017

I just upgraded to 3.0.5, seeing the warning but they are from a different package. I guess lots of modules out there still not brought into compliance