React-router: non-strict dependencies between packages

[frux]

I think it's a bad idea to set non-strict dependencies between your packages. I used react-router-dom: "4.0.0-beta.4" since you've broken [email protected]. And now my react-router-dom: "4.0.0-beta.4" installed react-router: "4.0.0-beta.6" so I've got an error.

[timdorr]

Yep, we should be doing this. A PR for this would be great (and really easy)!

Is this perhaps something Lerna can manage for us? I'll open up an issue over there to discuss.

[timdorr]

Ah wait, I think Lerna does do this. Maybe.

@mjackson Did you do 83f3459 with just lerna publish or was that by hand?

[mjackson]

lerna automatically manages the dependency versions for us and uses the ^. I'm going to revert 59513c9caeb31779d0d335560b254c18488771f9

[timdorr]

But you see why that's a problem, right?

[mjackson]

Yes, there's just not much we can do about it w/out altering lerna (unless there's some lerna flag I'm missing...). In the next release, the ^ is going to be back anyway.

[yasserkaddour]

@mjackson I think the flag you're looking for is --exact

From the lerna doc

$ lerna publish --exact
When run with this flag, publish will specify updated dependencies in updated packages exactly (with no punctuation), instead of as semver compatible (with a ^).

[timdorr]

Oh thank you! That's exactly what I was looking for.

[yasserkaddour]

You're welcome.

Be aware that flag was introduced in v2.0.0-beta.33, I would have made a PR to upgrade lerna, but I saw that @mjackson reverted to v2.0.0-beta.32 for some reason.