React-redux-starter-kit: react-router v4

Created on 5 Jan 2017  路  7Comments  路  Source: davezuko/react-redux-starter-kit

Hey, I'm really hyped about react-router v4. It's way cleaner. Have you seen presentation? Are you planning to switch to v4?

Most helpful comment

I am working on it in a fork here. I still need to rewrite the tests (I have no clue on how to test this) and find a way of linking the history to redux.
Also I am not sure about the asyncComponent approach, it seems to work but it may not be the best option (I found it there).
If @davezuko is interested, I'll make a pull request.

All 7 comments

I am working on it in a fork here. I still need to rewrite the tests (I have no clue on how to test this) and find a way of linking the history to redux.
Also I am not sure about the asyncComponent approach, it seems to work but it may not be the best option (I found it there).
If @davezuko is interested, I'll make a pull request.

@mesteche that would be great if you made a pr. Most likely would get approved.

I'm kind of puzzled now I've been playing with react-router v4.
I mean, the whole fractal route design may not be relevant with react router v4 anymore.
For instance you can have recursive routes, like in this example.
Fractal routes are great to represent a tree, but what if your routing doesn't look like a tree but a graph ?
Maybe this is a whole other question and I should open another issue. But since one of the goals of this starter-kit is to remain unopinionated, we should rethink all of this.
Anyway, I'll make a pull request once I get react-router working with redux again.

Some updates:
Last alpha of v4 was buggy and some major API changes are in their way with the release of the upcoming beta. So I will wait until then before resuming on implementing it.

@mesteche beta was just released today

Willing to accept a PR for this now that v4 is out and stable, otherwise I will try to get to it when I have time.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zeroc picture zeroc  路  4Comments

liubko picture liubko  路  4Comments

nickgnd picture nickgnd  路  4Comments

ciokan picture ciokan  路  4Comments

brandonmikeska picture brandonmikeska  路  4Comments