React-redux-starter-kit: speed up test build time breaks Codeship CI

[GerritWanderer]

Hey Devs,

after we merged the latest improvements regarding the test build time (commit 998cce613f42beb7db21cec79f32f13686acfc66), we recognized that our builds on Codeship CI are failing due to an SyntaxError: Expected token ']' error.
On our local machines (MacOSX and Ubuntu with PhantomJS 2.1.1) it works fine to run the tests though.

I can also easily reproduce this error, when I fork the original react-redux-starter-kit master and connect it with codeship. It breaks with this error and I assume it belongs to the karma-webpack-with-fast-source-maps package.

Screenshot is attached:

Any hints?

[davezuko]

Having never used Codeship, is there anything different about its environment than yours? I just signed up for Codeship and will try to reproduce, but it seems incredibly strange that this only occurs in that environment. On a related note, I also merged those same fixes into our applications at work (CircleCI) and we haven't run into any issues.

Will try to repro on Codeship and see how it goes.

[GerritWanderer]

No, never had the feeling that the codeship environment is different from ours. Thanks for investigating this issue.

[davezuko]

Well, reproducing at least: https://codeship.com/projects/134857/builds/12222450

[Pintouch]

I have the same error on CodeShip.

I think that is because the phantomjs version on codeship servers is "1.9.7", and on local I use "2.1.1".
I'm trying to make a script to update the phantomjs version on the CodeShip server.
I let you know if I find something.

[Pintouch]

Installing phantomjs 2.1.1 before running test solved the issue above but now, the build silently fails without any error...

I'll continue investigating, if you have some ideas, let me know.

[adrianObel]

I'm having the exact same problem when running tests on Codeship. Mine although is running on Phantom 2.1.1.

PhantomJS 2.1.1 (Linux 0.0.0) ERROR
SyntaxError: Expected token ']'

from test-bundler.js

[jeremyw]

Could this be related to https://github.com/eslint/eslint/issues/2228?

[gerbal]

Same Issue running tests inside a local Docker image

[gerbal]

I don't know what the cause of this was, but I resolved it by changing this line

from:

const __karmaWebpackManifest__ = [] // eslint-disable-line

to:

const __karmaWebpackManifest__ = new Array() // eslint-disable-line

Alternatively a semicolon at the end of the line seems to resolve the problem.

[davezuko]

@gerbal that's _so_ strange to me. Especially that it would only cause issues in very particular environments.

[davezuko]

All hail @gerbal .

Fixed with https://github.com/davezuko/react-redux-starter-kit/pull/709.

[GerritWanderer]

Thank you @gerbal for your research.