React-redux-firebase: feat(typings): general upgrade of typescript definitions/typings

[rscotten]

Hello,

Big fan of this library so far. Great job!

As a Typescript user, I'd like to help out on the Typescript definition file. I've forked the repo and have been upgrading the types on the 3.0.0-alpha.5 branch. I'll make a pull request when ready.

Just to make sure I'm not duplicating anyone's work,

is anybody else was working on this?

[prescottprue]

@rscotten I am definitely not working on the typings at the moment, thanks for reaching out to confirm. You can start from and PR against the next branch (where 3.0.0-alpha.5 was merged to) since the pre-release versions are getting merged there.

[prescottprue]

Reach out with any updates (even small ones). We can get changes out to the next tag/branch pretty quickly, and I am sure that there are others using typescript that would enjoy the changes.

[sambokai]

Commenting to voice my support for this move.

@rscotten Are you currently working on it?

I think typing the firebase instance you get from firebaseConnect or withFirebase would be very helpful.

[rscotten]

@sambokai yes, I have updated some types for the functions I'm using, but it's by no means complete.

You can see my current draft here: https://github.com/rscotten/react-redux-firebase/blob/v3.0.0-alpha.6-upgrade-ts-definitions/index.d.ts

[rscotten]

Just got motivated to work on this right now.

@prescottprue Any reason why this package has a package.json devDependency of "firebase": "4.12.0", instead of 5.8.1?

[rscotten]

@sambokai made some more progress on this. It's still not complete, but if you're in a pinch, you can replace your index.d.ts file with mine and it might help out some.

[sambokai]

Will try it and report back if i notice anything

[prescottprue]

@rscotten The old dev dependency is just from how long ago I set it, I'm sure it won't break anything.

Even if it isn't finished I am open to trying out some of the changes because I agree with @sambokai that the typings for firebaseConnect would be super useful

[rscotten]

@prescottprue I can submit a PR this weekend.

[idanlo]

@prescottprue I'm working on some types, will open a PR to the next branch soon.

[rscotten]

@prescottprue @idanlo I submitted my PR: https://github.com/prescottprue/react-redux-firebase/pull/627

[prescottprue]

Just did a pretty big upgrade to the types as part of the v3.0.0-alpha.13 release and am planning to continue updates to them regularly. Going to close this issue for now, but please feel free to open new issues/PRs with your input. Thank you everyone for all for your contributions!