React-redux-firebase: bug(helpers): isLoaded incorrectly returns false on non-existing data that is loaded using storeAs

[optimistiks]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

If you use storeAs, isLoaded will return false on the related data item, if that item does not exist in the actual database.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via codesandbox or similar.

Example:

firestoreConnect([{ collection: "items", doc: "myItem", storeAs: "myItem" }])

Before loading, firestore.data looks like this - {} (empty object). firestore.data.myItem is undefined, isLoaded(firestore.data.myItem) is false, which is correct.

After loading, firestore.data looks like this - { myItem: undefined }, isLoaded(firestore.data.myItem) is false, which is incorrect.

What is the expected behavior?

isLoaded should be true after loading.

Which versions of dependencies, and which browser and OS are affected by this issue? Did this work in previous versions or setups?

"react-redux-firebase": "^2.2.2"

[prescottprue]

undefined usually means that the value is not loaded yet for Real Time Database, since the value is null if it is loaded and does not exist. Are you sure you aren't getting query errors of some sort? Maybe related to rules?

Other than that, wondering which version of redux-firestore you are running.

[optimistiks]

Nope, no errors, nothing like that. I'm using redux-firestore 0.6.0. I did some debugging - the problem might be there: https://github.com/prescottprue/redux-firestore/blob/master/src/reducers/dataReducer.js#L47

Let's say I try to load a document, /subscriptions/user_1 (and it does not exist in the db), and store as "subscription". It means: { collection: "subscriptions", doc: "user_1", storeAs: "subscription" }.

At this point, at line 47, payload.data is null, which is correct.
But docName at this point equals user_1 because of the getDocName function.
So what happens is this code gets executed get(payload.data, docName), which means get(null, "user_1"). And at this point data becomes undefined

[prescottprue]

Interesting, thanks for the input from your debugging. Always open to a suggested code change if you get the time, otherwise I will try to look into it soon.

[optimistiks]

Sorry, I don't have time to make a PR, but here is another example of the bug, but now I'm not even using "storeAs". Trying to load non-existing data, /books/123. In redux, store.firestore.data.books.123 should become null after loading, but it is undefined, and isLoaded(state.firestore.data.books.123) is always `false. Hopefully it will help to catch that bug.

[prescottprue]

I believe that if you also check for the list before hand (i.e. isLoaded(state.firestore.data.books) && isLoaded(state.firestore.data.books.123) ) things should work as expected if not, lets open an issue on the redux-firestore repo so it doesn't get lost. Thanks for reporting!