React-quill: Bump version to Quill 1.0?

[clemmy]

Quill 1.0.0-beta.1 has been released and it contains many bug fixes. There are some breaking changes listed here: http://beta.quilljs.com/guides/upgrading-to-1-0/. Are there plans for a version bump soon?

[clemmy]

I'm working on a fork here: https://github.com/wifast/react-quill

[Nazanin1369]

I have already upgraded the Quill to 1.0.0-beta.2 in my pull request here:
https://github.com/zenoamaro/react-quill/pull/98

[clemmy]

Hello Nazanin, I checked out your pull request and although it is working, it doesn't allow font family and font size customization like the previous version from what I can see. I also submitted a pull request here: https://github.com/zenoamaro/react-quill/pull/99, but I am still working out some bugs. However, it is for the most part complete, and you can check out the demo here: http://wifast.github.io/react-quill/

[Nazanin1369]

Hi Clement,

I do not see the clode blocks implemented in your demo.
So since we have a wrapper around Quill itself we can change the font
family and size customization to stat the same. But is that a requirement?
Either we can have another commit to make it work with previous font size
if it is.

On Thursday, May 26, 2016, Clement Hoang [email protected] wrote:

Hello Nazanin, I checked out your pull request and although it is working,
it doesn't allow font family and font size customization like the previous
version from what I can see. I also submitted a pull request here: #99
https://github.com/zenoamaro/react-quill/pull/99, but I am still
working out some bugs. However, it is for the most part complete, and you
can check out the demo here: http://wifast.github.io/react-quill/

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zenoamaro/react-quill/issues/93#issuecomment-222035448,
or mute the thread
https://github.com/notifications/unsubscribe/AGFV2CMfIR71beo9kpjoHC8F8i_XXH_yks5qFkKWgaJpZM4Icg5d
.

Best Regards,

[Nazanin1369]

Are you guys having slack channel for communication on this repo? We should find a way merging our PRs.

[clemmy]

Hi Nazanin, I'm not aware of any slack channel for communication at this point in time. In terms of whether it is required or not, I am simply following the behavior this project previously had. We should see if @zenoamaro has any input on this, and where he wants the direction of react-quill to go.

[Nazanin1369]

Sure, I also can put up another PR after you have merged your pull request only for code blocks if you are willing to merge your upgrade.

[MasahiroMorita]

I'm looking forward to this! I really need this version of Quill.

[thomas-jeepe]

Updates?

[clemmy]

@MasahiroMorita @thomas-jeepe There is a working version I wrote located here: https://github.com/zenoamaro/react-quill/pull/99. However, it doesn't expose the API for settings custom formats yet.

[thomas-jeepe]

Alright, thanks for the response

[alexkrolick]

https://github.com/alexkrolick/react-quill

Added support for using modules to configure toolbar, formats, keyboard, etc.

@clemmy @MasahiroMorita @thomas-jeepe

[zenoamaro]

Thanks to the great work of @clemmy and @alexkrolick, ReactQuill is now updated to Quill 1.0.

Closing this in favor of #113.