React-query: refetchOnWindowFocus necessary for inactive queries?

Created on 12 Mar 2020 · 5Comments · Source: tannerlinsley/react-query

Hi, I have a page with some data and a faceted search, a new search request is executed every time I add a filter (as expected), but if I change to another window and then return, the refetchOnWindowFocus executes not only for the current query but all inactive search queries.

Is there a usefulness to this behavior that I'm not seeing?

Can we maybe add some way to avoid this? I can do the PR.

(react-query version 1.0.17)

Source

ivowork

Most helpful comment

Interesting. I’ll take a deeper look at this
On Mar 12, 2020, 9:28 AM -0600, Ivo Anastácio notifications@github.com, wrote:

@tannerlinsley please check the video, to the best of my understanding the queries are inactive.
http://somup.com/cYeloOhkkL
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

tannerlinsley on 12 Mar 2020

👍4

All 5 comments

It shouldn't be refetching inactive queries, only stale queries. Are you sure they are inactive and not stale?

tannerlinsley on 12 Mar 2020

@tannerlinsley please check the video, to the best of my understanding the queries are inactive.

http://somup.com/cYeloOhkkL

ivowork on 12 Mar 2020

Interesting. I’ll take a deeper look at this
On Mar 12, 2020, 9:28 AM -0600, Ivo Anastácio notifications@github.com, wrote:

@tannerlinsley please check the video, to the best of my understanding the queries are inactive.
http://somup.com/cYeloOhkkL
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

tannerlinsley on 12 Mar 2020

👍4

I confirm, here's a codesanbox: https://codesandbox.io/s/goofy-thunder-kzfgw

I'll submit a PR later