React-popper: "ReferenceError: babelHelpers is not defined" in version 0.10.2 (not in 0.10.1)

[davidxmoody]

Reproduction demo

Steps to reproduce the problem

1. I'm using material-ui beta 44 which uses react-popper as a dependency (bundled with create-react-app typescript scripts)

What is the expected behavior?

It should compile.

What went wrong?

I get the following error:

ReferenceError: babelHelpers is not defined
(anonymous function)
node_modules/react-popper/lib/Manager.js:5
  2 | import PropTypes from 'prop-types';
  3 | 
  4 | var Manager = function (_Component) {
> 5 |   babelHelpers.inherits(Manager, _Component);
  6 | 
  7 |   function Manager() {
  8 |     var _ref;

Any other comments?

Installing 0.10.1 manually fixes the problem. I can provide more info if necessary although given that the new version was only just released, I was hoping it would be an obvious fix.

Packages versions

• Popper.js:
• react-popper: 0.10.2

[FezVrasta]

@virgofx since you worked on the 0.10.2 changes, may you have a look?

[TrySound]

@FezVrasta external-helpers should be added only for rollup build. For babeled files it shouldn't not be added.

[TrySound]

Here it can be moved to rollup config
https://github.com/FezVrasta/react-popper/blob/v0.x/.babelrc#L8

[virgofx]

Investigating

[FezVrasta]

0.10.3 fixes it

[virgofx]

@TrySound @davidxmoody Can you check 0.10.3 and confirm fixed?

[FezVrasta]

The babelhelpers are not referenced in the file anymore so hopefully yes.

https://unpkg.com/[email protected]/lib/Manager.js

But I just noticed that the package.json points to an invalid main path, is it still related to your PR maybe?

[virgofx]

I actually didn't change the package.json file (not too familiar with the main or umd:main references). ... but the locations should be updated. I'm sure I could submit a new PR to update those. It seems like they should be updated (good catch).

Should the main point to the lib/react-popper.js or the CJS file? and umd:main to the new dist/umd/react-popper.min.js file?

[TheSharpieOne]

also consider jsdelivr and unpkg properties in the package.json (and maybe even cdn). They are properties which help the CDNs determine which file to server.
See:
https://github.com/unpkg/unpkg/issues/63
https://github.com/jsdelivr/jsdelivr#publishing-packages

[oliviertassinari]

0.10.3 introduces another problem. package.json references dist/react-popper.js but this file doesn't exist.

[oliviertassinari]

Fixed in https://github.com/FezVrasta/react-popper/commit/65c3fb5c0786bb250454087d2de1489c55a19587

[FezVrasta]

0.10.4 should be fine hopefully