React-player: Feature request: Add Vidyard and Hubspot Video Support
It would be fantastic if support for Vidyard (which also powered Hubspot Video) were added. Happy to collaborate on making it happen as well.
In case it would help, here are some of the documentation pieces I would recommend referencing:
Vidyard Player API (responsive player layout), or
Vidyard Legacy Player API (non-responsive)
josephfung
All 10 comments
any plans or updates for this?
JohnMusleh
on 25 Mar 2020
I don't want to add support for other types of video before I refactor a bit to enable lazy loaded players. Right now the default export includes the code to play all types of URL, even if you are only ever using one type.
Just a case of getting enough free time...
cookpete
on 25 Mar 2020
@CookPete Thanks for the explanation, that's helpful to understand. Supporting better lazy-loading is a good call for this case.
I realize this is a side-project, would something like a bounty be of help?
FWIW I checked, but didn't see any Patreon, buymeacoffee, or other sponsorship links on your profile...happy to be pointed that way 馃憤
josephfung
on 25 Mar 2020
@josephfung I've been meaning to for a long time. Just set one up now: https://www.patreon.com/cookpete
cookpete
on 26 Mar 2020
Great! Done!! Thanks again for the great component!
josephfung
on 26 Mar 2020
@josephfung Try out some Vidyard URLs with [email protected] and let me know if they work. 馃帀
cookpete
on 28 Mar 2020
@CookPete Amazing! thank you! 馃檹 Works perfectly!
I see there were a lot of changes to incorporate that lazy-loading too - both sets of changes are very much appreciated!
josephfung
on 28 Mar 2020
Yeah the lazy players was a result of #738 so I figured the 2.0 alpha would be a good way to quickly get something working to you.
Glad to hear it's working. Thanks so much for becoming a patron! If you know any other formats of Vidyard URL that people may use, let me know so I can adjust the regex. 馃憤
cookpete
on 28 Mar 2020
Thanks - I'll check with the team.
Off the top of my head, the only variation I know of, is that people can set a vanity URL (so other than share.vidyard.com the domain could be something like videos.mydomain.com). Not as many people do that, though, so I'm not sure if it's really a big use-case.
Either way - this is great, thanks! We have a PR in code review already incorporating the new version :D
josephfung
on 28 Mar 2020
@josephfung v2.0.0 is here!
cookpete
on 25 Apr 2020
Related issues
mrcoles
路
5Comments
Betree
路
4Comments
MDrooker
路
6Comments
pwbrown
路
8Comments
Thargarius
路
3Comments
Most helpful comment
I don't want to add support for other types of video before I refactor a bit to enable lazy loaded players. Right now the default export includes the code to play all types of URL, even if you are only ever using one type.
Just a case of getting enough free time...