React-pdf: Accessing PropTypes via the main React package is deprecated

[8ctopotamus]

Awesome package! :D

I am getting this warning when importing though:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

[jjhamshaw]

also getting the same warning using version... "react-pdf": "^1.6.1"

[mrobrian]

I have version 1.6.1 (verified in package.json within node_modules/react-pdf) but my react-pdf/src/react-pdf.jsx file is different from what I see on github. Maybe something went wrong with the npm repo? Not sure. But this issue should be resolved with the code in react-pdf.jsx that is currently on github with the version 1.6.1.

Also, I was thinking I could get around the issue by using a git link in my package.json to grab the code. If I do "git://github.com/wojtekmaj/react-pdf" it gets version 1.6.1 but I still get the warnings. The es5/react-pdf.js file still uses React.PropTypes, but the src/react-pdf.jsx file does not (possibly a build failed?). The other issue is that in my project we are required to lock down package versions, and if I do "git://github.com/wojtekmaj/react-pdf#v1.6.1", to specify the v1.6.1 tag, I get version 1.6.0. Same if I use the commit hash from 1.6.1.

[wojtekmaj]

Hey,
I just updated master branch with new files, also built on Webpack 3.2 now. Next release is coming shortly :)

If you want to check this, temporairly change your package.json so it would say
"react-pdf": "git+ssh://[email protected]/wojtekmaj/react-pdf.git"

Let me know what you think!

[mrobrian]

I was able to test it using "react-pdf": "git://github.com/wojtekmaj/react-pdf.git#c078b4a" to grab a specific commit (the latest at the time) and it does resolve the prop types warnings 👍

[wojtekmaj]

Fixed in 1.7.0.

[8ctopotamus]

I just tried updating to 1.7.0.

Now I am getting this error:

Error in ./~/pdfjs-dist/webpack.js
Module not found: 'worker-loader' in C:\Users\joshn\Documents\github\sabine-hill-tile-customizer\node_modules\pdfjs-dist

 @ ./~/pdfjs-dist/webpack.js 18:18-64

[wojtekmaj]

Hey @8ctopotamus , sorry for the inconvenience! Please try the latest (1.8.2).

[8ctopotamus]

Awesome, works great! Thanks for the quick response!