React-native: Migrate off of old context APIs

[TheSavior]

We want to get rid of our usage of the prop-types package. The last remaining usage of this is a couple of old components that use the old React context API. We need to migrate these components to use the modern React.createContext API.

The components using the old context API are:

• VirtualizedList
• Modal (@satya164)
• AppContainer (@safaiyeh)
• Incremental (@venits)

For more information about the old API and how to migrate to the new API you can check out the React docs for Context: https://reactjs.org/docs/context.html#classcontexttype

If we are able to remove the usage of prop-types from React Native we should be able to substantially lower the bundle size of React Native. We'd love your help!

[Naturalclar]

I'd love to help out! Could I work on Modal?

[venits]

I would love to take care of Incremental :)

[mikaoelitiana]

hey there, I can check virtualizedlist

[thymikee]

@Naturalclar @mikaoelitiana they're all yours to take :)

[mikaoelitiana]

@thymikee thanks, I am already working on VirtualizedList, the module is quite big and I try to make sure I am doing things the right way

[TheSavior]

It looks like Modal actually only uses the VirtualizedList Context and AppContainer Context, it doesn't have its own context. So we need to get the VirtualizedList and AppContainer ones done first.

[mikaoelitiana]

So this means these contexts need to be exported, right?

[TheSavior]

Yeah, the root tag context is already exported, unstable_RootTagContext, the VirtualizedList one can be exported as a static property on VirtualizedList: VirtualizedList.Context

[thymikee]

@TheSavior is the VirtualizedList context used internally at FB? It looks like Modal overwrites the virtualizedList context with null, so it doesn't propagate further and there are no consumers of this inside RN codebase. So, if there are no internal FB components using this context, we could maybe kill it entirely? But I guess there are 😄

[TheSavior]

Yeah, these contexts are all used fairly heavily. Any kind of portal type thing would use it like Modal or BottomSheet.

[joelbrewer]

It appears all of the tasks on this issue have been claimed? Looking for my first RN issue to help out on :)

[awalmubarak]

It appears all of the tasks on this issue have been claimed? Looking for my first RN issue to help out on :)

It appears so. I wanted to work on this but i'll have to move on to another issue

[thymikee]

VirtualizedList was migrated in https://github.com/facebook/react-native/commit/7bd694fc6f4bb027b6d7ee04034cad41a43e5695. So only AppContainer left now

[gdstewart]

Is AppContainer still taken? Or could I give it a try?

[MayheMatan]

can i give appContainer a try too?

[gittysachin]

If no one is working on AppContainer, then I'd like to take it up. Thanks!

[mohamadhamad300]

do you can give me simple task to contribute it