React-native: Margin affects padding inside button (0.54.2) sdk 26

[nikolal]

Environment:
OS: OS X El Capitan 10.11.6
Node: 8.4.0
Yarn: 1.3.2
npm: 4.6.1
Watchman: 4.7.0
Xcode: Xcode 8.2.1 Build version 8C1002
Android Studio: 2.2 AI-145.3537739

Packages: (wanted => installed)
react: 16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: https://github.com/expo/react-native/archive/sdk-26.0.0.tar.gz => 0.54.2

Steps to Reproduce
1 - uncomment marginTop

Expected Behavior

• Text inside button should be centralized

Actual Behavior

• Text is moved on top of the button

Reproducible Demo
https://snack.expo.io/SJhhndX3G

This is happening after updating to React native 0.54.2

[nikolal]

I created issue on expo board first. They pointed to several commits in React Native repo.

https://github.com/expo/expo/issues/1667#issuecomment-382159045

[FlaviooLima]

Only Happens with margin declared with a percentage and it stills happens in react-native v0.55.3

19164

[stale[bot]]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

[artdent]

I just verified that this issue is still present in v0.57.0.

[nikolal]

I also still have this issue.

[brettdh]

This is not just an Android issue; as the erroneously-closed #19164 indicates. I'm experiencing it as well on iOS.

[brettdh]

This only appears to apply for percentage margins, not integer margins:
https://snack.expo.io/Byj4wSvhQ

[artdent]

I was still able to reproduce this on react-native 0.59.1.

[cpojer]

Is there somebody who'd like to send a PR with a fix for this issue?

[stale[bot]]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[brettdh]

This is still an issue, as the Snack I linked above demonstrates.

EDIT: forgot to update Expo SDK version (and thus React Native version). Retesting...

[brettdh]

Just tested it again with Expo SDK 32 and 34. Same (still broken) behavior in both (tested iOS).

Interestingly, the behavior is correct in expo-web.

[garronej]

Still broken

[jimpala]

Still broken!

[FlaviooLima]

I can't understand why this is still in the same state without a single higher up reckon this issue or give some info about it!
:/

[stale[bot]]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[garronej]

Is it fixed now?

[FlaviooLima]

@garronej Version 0.61.5 and still happening

[stale[bot]]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[garronej]

@stale It hasn't been fixed, please leave it open.

[stale[bot]]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[jimpala]

@stale very much not fixed 😘

_{Sent with GitHawk}