React-native: onSubmitEditing not working on TextInput when Multiline={true} in React Native(android)

[nikasvan]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS High Sierra 10.13.2
Node: 7.10.1
Yarn: Not Found
npm: 4.2.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: https://github.com/expo/react-native/archive/sdk-21.0.2.tar.gz => 0.48.4

Steps to Reproduce

On iOS there is no problem, but on Android when I have multiline TextInput, onSubmitEditing doesn't seem to work. User types some symbols in input and when pressing return key I am expecting to stop typing option, save already typed symbols, but instead new line appears below and user continues to type.

<TextInput
  multiline
  onSubmitEditing={text => this.saveCurrentValues()}
/>

Expected Behavior

When 'return' key is pressed TextInput shouldn't break and on new line. Like it is on iOS, it should listen to onSubmitEditing()

Actual Behavior

When 'return' key is pressed there shouldn't be a new line.

[rajivshah3]

Try this: https://facebook.github.io/react-native/docs/textinput.html#bluronsubmit
The blurOnSubmit prop works differently on multiline fields

[SuhairZain]

@rajivshah3 I believe that @nikasvan expects the exact same thing as given in the doc, that it will not insert a new line and instead call onSubmitEditing. But it doesn't happen, which is why he opened this issue. I'm also having this issue.

[react-native-bot]

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

_{How to Contribute • What to Expect from Maintainers}

[salmanwaheed]

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:

[email protected]
Domain salmanwaheed.info has exceeded the max emails per hour (160/150 (106%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------
Received: from o10.sgmail.github.com ([167.89.101.201]:36575)
by box1177.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.89_1)
(envelope-from )
id 1epQUu-003IzE-0t
for [email protected]; Fri, 23 Feb 2018 20:27:40 -0700
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=jmpzFN0deMfrbYD6uBqEIcl37eo=; b=MBNxJoMGKqDsrUEm
jP+qxjip8XYmhfGozesrFFLbA4xuUtSHZz2nfoo0RghGRpZHHMrB2oII+Sc3zVkX
//55T6vuH53QwBZRpsGkJ3IMmKSDnLph98LUo9eK7ULjntBiZuStWhAnxKezCZ40
RTAAWTcxUhpRQseAxUmWnqyOtK0=
Received: by filter0315p1iad2.sendgrid.net with SMTP id filter0315p1iad2-28983-5A90DBA1-8
2018-02-24 03:27:29.241462262 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16])
by ismtpd0002p1iad2.sendgrid.net (SG) with ESMTP id EoxBTxkuR3m2scx8dRCawQ
for [e-mail]; Sat, 24 Feb 2018 03:27:29.223 +0000 (UTC)
Date: Sat, 24 Feb 2018 03:27:29 +0000 (UTC)
From: React Native Bot [e-mail]
Reply-To: facebook/react-native [e-mail]
To: facebook/react-native [e-mail]
Cc: Subscribed [e-mail]
Message-ID:
In-Reply-To:
References:
Subject: Re: [facebook/react-native] onSubmitEditing not working on TextInput
when Multiline={true} in React Native(android) (#17825)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5a90da52cf71_ac92b2274f14ed038765b";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: react-native-bot
X-GitHub-Recipient: salmanwaheed
X-GitHub-Reason: subscribed
List-ID: facebook/react-native
List-Archive: https://github.com/facebook/react-native
List-Post: [e-mail]
List-Unsubscribe: ,
https://github.com/notifications/unsubscribe/AO8bONT0iw1xfx0jDqV5TvUXCY2deNK1ks5tX4BSgaJpZM4R2CW1
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: [email protected]
X-SG-EID: 92ws1MVnlto3blxqXlf5goB0ee0kdDGWR6vcWx8d649bfpXd+3mTQPYbtkU5EjkqUOWAseZtSDc3Lh
vjiofxOlWLXTKsmUo3f4R+57RFDs5VanqZMwDmsYB5z4PxzCPbcx1KkJIC6ybwyBHzlfBncqv6sLdv
K5hmCdWKMjJEEBNq3S/FR8+nD4olUF4EnL8AHRKEy4vIBPFaCzpCr7AhK94kMaqIWuEB07V04+GBXV
k=
X-Spam-Status: No, score=-0.0
X-Spam-Score: 0
X-Spam-Bar: /
X-Ham-Report: Spam detection software, running on the system "box1177.bluehost.com",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
root\@localhost for details.

Content preview: Closed #17825. -- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: https://github.com/facebook/react-native/issues/17825#event-1490267194
[...]

Content analysis details: (-0.0 points, 5.0 required)

pts rule name description

---

0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked.
See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information.
[URIs: github.com]
-0.5 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 HTML_IMAGE_ONLY_24 BODY: HTML: images with 2000-2400 bytes of words
0.0 HTML_MESSAGE BODY: HTML included in message
2.5 DCC_CHECK No description available.
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid
-1.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4)
[167.89.101.201 listed in wl.mailspike.net]
-0.8 RCVD_IN_MSPIKE_WL Mailspike good senders
-1.5 AWL AWL: Adjusted score from AWL reputation of From: address
X-Spam-Flag: NO

----==_mimepart_5a90da52cf71_ac92b2274f14ed038765b
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Closed #17825.

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebook/react-native/issues/17825#event-1490267194
----==_mimepart_5a90da52cf71_ac92b2274f14ed038765b
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Closed #17825.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5a90da52cf71_ac92b2274f14ed038765b--

[DeforeChen]

If the blurOnSubmit is set to true, although the onSubmitEditing would be called instead of inserting a new line, the keyboard would also dismiss at the same time. I do not want the keyboard be hidden when submit function fired, any way to solve this ?

[GitHubTracey]

I am experiencing the exact same as @DeforeChen. I have some inputs where I need to allow the user to be able to type multiple lines (with word wrap), but not allow them to actually enter a new line. It is especially weird behaviour when you are trying just go to the next field, and instead, it adds a new line, and then goes to the next field... so you can get multiple new lines in fields where you don't expect any.. I can clear after, but that's not a smooth experience for the user.