React-native: [0.49] Commits to cherry-pick into stable release

[grabbou]

[fernandopasik]

Apparently v0.49.0-rc.0 wasn't published to npm.
https://circleci.com/gh/facebook/react-native/20652

[grabbou]

Yeah, we are aware of this. @hramos - any updates on the Buck step getting
commented out?

On Sat, 2 Sep 2017 at 19:24 Fernando Pasik [e-mail] wrote:

Apparently v0.49.0-rc.0 wasn't published to npm.
https://circleci.com/gh/facebook/react-native/20652

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/15749#issuecomment-326758093,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxqcNPTS0qDSMEDK0RaWBpOmeXxgsks5seY9bgaJpZM4PKRxn
.

[janicduplessis]

Fix a scroll event regression https://github.com/facebook/react-native/commit/e964a7f4ef93fcadf5cfd1c269b77b13cb3be374.

We might want to also include this in a 0.48 patch

[iegik]

0fa02ff154922df64bf45ad2e04888c5c125e5ad

[ide]

@grabbou Do we need https://github.com/facebook/react-native/commit/8a85546ef95aa92865af0cd17278afe286355677?

[hramos]

@grabbou waiting for a fix to be applied, I think it's alright to comment out the test until that is in place. I'll open a PR.

[nihgwu]

https://github.com/facebook/react-native/commit/d3007b0fd268c0d69f92983ef315e7c46cc85c83
can we also cherry-pick this to 0.48?

[ide]

Cherry-picked:

• e964a7f (Fix scroll events getting skipped on Android) (also in 0.48.2)
• d3007b0 (Fix fontWeight regression on iOS) (also in 0.48.2)
• 8a85546ef95aa9286 and 7d04fbaba29b7c55a40edce (fixes for the RCTMultipartStream reader commit we reverted in 0.48 but that is included in 0.49)

These are going out with 0.49.0-rc.1.

I did not cherry pick 0fa02ff since the header import hadn't changed for months before and people were compiling fine. Not sure of the scope of the change.

[fernandopasik]

The Buck step is still failing
https://circleci.com/gh/facebook/react-native/20918

v0.49.0-rc.1 wasn't published again :(

[hramos]

Comment out the failing buck test, so we can proceed with npm publish

We can work around this once we move to circleci2

[fernandopasik]

Cool I see your PR doing this #15859

[janicduplessis]

https://github.com/facebook/react-native/commit/64be88398d4c966b24d2f4feeae54db459f75e5f Fixes a regression with contentOffset

[hramos]

That PR only applies the change to master. You’ll want to do the same on the release branch.

[fernandopasik]

4e2c084 is ready to cherry pick with buck comment out for releasing 0.49.x

[ide]

Cherry-picked https://github.com/facebook/react-native/commit/30087f972609ac40b6e0067e29539602e11d75c7 (Comment out Flow tests) and https://github.com/facebook/react-native/commit/4e2c084fd88d4864fb7565446703e79cf1421f31 (Comment out failing Buck tests) to 0.49-stable and sent 0.49.0-rc.2 to CI.

[nihgwu]

0.49.0-rc.2 failed again

[fernandopasik]

0.49.0-rc.2 is released!! 🥇

[ide]

Cherry-picked https://github.com/facebook/react-native/commit/7b770556ac6eb60094bdf59bfd14876b6e2a1307 (improve RCTCxxBridge invalidation -- fixes a crash when you try to reload after an error sometimes). Publishing 0.49.0-rc.3 -- please give this a try if you're using RCs and the CxxBridge on iOS.

[grabbou]

The build has failed - @ide do you have write access to trigger reload on CI? CC: @hramos

[ide]

Cherry-picked a few more fixes and bumped to 0.49.0-rc.4:

• Android Oreo (8.0) support for targeting API 26: https://github.com/facebook/react-native/commit/96de23abf1663c568b259733b0665c342b23ffb5
• Support multiple roots for symlink discovery in the packager: https://github.com/facebook/react-native/commit/39f83c4a12b8350e331c3a6c575a2cab64950d7a
• Fix iOS crash when loading photo library assets with a nil URL: https://github.com/facebook/react-native/commit/7fab093fc848e0a101586d79a927480d42d5ea47

[ide]

Cherry-picked a fix for Jest tests into 0.49.0-rc.5:

• Add BlobModule native module mock to jest setup: https://github.com/facebook/react-native/commit/165f87673002dec640fe86486296cd0d0847b333

[ide]

Cherry-picked janic's version checking into 0.49.0-rc.6:

• Validate that JS and Native code versions match for RN releases: https://github.com/facebook/react-native/commit/1af645b2fd9ba98d740df70eaf69dd58fba273d1

The native and JS code for this release must match (if not, RN will display a red box with a clear error saying the native and JS versions don't match).

[fungilation]

Release AGAIN missing on npm. Intentional?

[kelset]

@fungilation there's a reason why it's tagged as "Pre-release".

[grabbou]

Yes, it's "pre-release" because its still release candidate. It is on npm
and can be installed just like any other RC. Either npm install react-native@next or lock to specific version.

Will be public latest version later today - we were working on the
changelog yesterday. I will be tweeting about it in few hours.

On Wed, 4 Oct 2017 at 15:46 Lorenzo Sciandra [e-mail]
wrote:

@fungilation https://github.com/fungilation there's a reason why it's
tagged as "Pre-release".

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/15749#issuecomment-334159896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxslqoxY6vkBzyjtM0MHBhd-xj_Yfks5so4xEgaJpZM4PKRxn
.

[grabbou]

The reason the version number is 0.49.0 and not -rc.7 just like most of
the times is that we have lost the changelog accidentally during the
release yesterday. I had to recreate it and so, until that happens, I have
temporarily tagged that version as next, so people don't install a
version w/o changelog.

On Wed, 4 Oct 2017 at 16:06 Mike Grabowski [e-mail] wrote:

Yes, it's "pre-release" because its still release candidate. It is on
npm and can be installed just like any other RC. Either npm install react-native@next or lock to specific version.

Will be public latest version later today - we were working on the
changelog yesterday. I will be tweeting about it in few hours.

On Wed, 4 Oct 2017 at 15:46 Lorenzo Sciandra [e-mail]
wrote:

@fungilation https://github.com/fungilation there's a reason why it's
tagged as "Pre-release".

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/15749#issuecomment-334159896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxslqoxY6vkBzyjtM0MHBhd-xj_Yfks5so4xEgaJpZM4PKRxn
.

[fungilation]

I see. I assumed it's a release with the 0.49.0 tag.
On Wed, Oct 4, 2017 at 7:10 AM Mike Grabowski [e-mail]
wrote:

The reason the version number is 0.49.0 and not -rc.7 just like most of
the times is that we have lost the changelog accidentally during the
release yesterday. I had to recreate it and so, until that happens, I have
temporarily tagged that version as next, so people don't install a
version w/o changelog.

On Wed, 4 Oct 2017 at 16:06 Mike Grabowski [e-mail] wrote:

Yes, it's "pre-release" because its still release candidate. It is on
npm and can be installed just like any other RC. Either npm install react-native@next or lock to specific version.

Will be public latest version later today - we were working on the
changelog yesterday. I will be tweeting about it in few hours.

On Wed, 4 Oct 2017 at 15:46 Lorenzo Sciandra [e-mail]
wrote:

@fungilation https://github.com/fungilation there's a reason why it's
tagged as "Pre-release".

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/facebook/react-native/issues/15749#issuecomment-334159896
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ACWcxslqoxY6vkBzyjtM0MHBhd-xj_Yfks5so4xEgaJpZM4PKRxn

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/15749#issuecomment-334167062,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoJShOqqCGQbuCb1LOlTnAIJZ80A8Wnks5so5HmgaJpZM4PKRxn
.

>

Cheers,
Gary