React-native: [0.46.0] react-native link is broken

[ttdat89]

Is this a bug report?

Yes

Environment

1. react-native -v: 0.46

Then, specify:

1. Target Platform (e.g. iOS, Android): Android
2. Development Operating System (e.g. macOS Sierra, Windows 10): MacOS Sierra
3. Build tools (Xcode or Android Studio version, iOS or Android SDK version, if relevant): SDK 25

Steps to Reproduce

1. react-native init
2. yarn add react-native-svg (or any package that need to be linked to native projects)
3. react-native link

Expected Behavior

react-native-svg is linked to Android project

Actual Behavior

Nothing happen

[hopeMing]

+1

[kuniiskywalker]

+1

[grabbou]

It's fixed in master, I am cherry-picking and releasing a fix later today. Thanks for the report.

[tak3mat3k]

@grabbou did you release the fix?

[grabbou]

Not yet, waiting for major packager fix to release one version at a time.

On Fri, 7 Jul 2017 at 00:33 Takeshi Kajino [e-mail] wrote:

@grabbou https://github.com/grabbou did you release the fix?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/14857#issuecomment-313537238,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxuwKG4c2uHqk1dWXklkXbSmXqAodks5sLWDFgaJpZM4OPW1r
.

[w8choi]

shouldn't it be open until the fix is actually released?

[grabbou]

It's being released now, please try 0.46.1 in like an hour.

[w8choi]

still doesn't link properly on Android (doesn't add compile project on app/build.gradle and if I run react-native link again, it makes duplicate on settings.gradle and MainApplication.java)

[danieljvdm]

I'm getting this behavior on 47

[alex1a]

Still happening to me.

Archlinux Base Devel (Seed: reactnativeseed)

npm: 5.8.0 (Installed via pacman)
node: v9.11.1 (Installed via pacman)
react-native-cli: 2.0.1 (Installed via npm globally - react-native-cli)
react-native: 0.51.0 (Installed via npm globally - react-native-cli)