Two commits for the 0.47 branch to get CocoaPods working right with the new bridge:
1ef21ece92e44256691e7449c96da808da977c45
26f01faf1b3f801501f77d47b00e05fb8a8b3b32
Thanks! cc @javache
This one too then, if we're aiming for a fully working Podspec in 0.47: https://github.com/facebook/react-native/commit/6c2beaffdcfa52c23012d7a8e0ffd6de0405d1a3
I went ahead and cherry-picked those three commits (1ef21ec, 26f01fa, 6c2beaf) and pushed 0.47.0-rc.1. Think it will be good if people can start testing the Podspec (and therefore RN 0.47 in general as well) early.
Thanks! Now we can also cherry-pick
https://github.com/facebook/react-native/commit/9afb71fde8199156ed683dca6aa59826f9fb9279
as
it finally landed.
On Fri, 7 Jul 2017 at 21:45 James Ide notifications@github.com wrote:
I went ahead and cherry-picked those three commits (1ef21ec
https://github.com/facebook/react-native/commit/1ef21ece92e44256691e7449c96da808da977c45,
26f01fa
https://github.com/facebook/react-native/commit/26f01faf1b3f801501f77d47b00e05fb8a8b3b32,
6c2beaf
https://github.com/facebook/react-native/commit/6c2beaffdcfa52c23012d7a8e0ffd6de0405d1a3)
and pushed 0.47.0-rc.1. Think it will be good if people can start testing
the Podspec (and therefore RN 0.47 in general as well) early.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/14840#issuecomment-313775433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxuIIFp7h_lHPBq7BQc8fy6bPUVNcks5sLorVgaJpZM4OOy9u
.
Please pick https://github.com/facebook/react-native/commit/e43c061e95d3da22b5876f06eee21225abce48f1 which fixes another Podspec issue
Picked e43c061 and sent 0.47.0-rc.3 to CI. (9afb71f is part of 0.47.0-rc.2).
Could we pull https://github.com/facebook/react-native/commit/7e29b1fc7711a285765f021be3e83a981b066435 in? Binary websocket comms are broken on Android (since 0.46) otherwise. (eg https://github.com/rh389/react-native-paho-mqtt/issues/5).
Cherry-picked 7e29b1f (fixes binary WebSocket messages) and 113e046444e090e38f89574620210ba86b711fed (exposes option to turn off .babelrc lookup algorithm instead of having to find and remove node_modules/**/.babelrc). The podspec documentation fix was already cherry-picked. 0.47.0-rc.5 is now in CI.
@brentvatne asked for b8fafb46c1ea1ecfa75b88cd1b494a7720afb046 to be cherry-picked into 0.47
please pick 63c2ab3eb13c50e1cdd686b1f8913d569a7af53a so that android toolbar works properly.
I am wrapping up changelog for this release and cherry-picking those commits. Stable should be on its way pretty soon.
If possible, cherry pick 471c9da4d6c404459973d22c27b847f33e699c8c which will fix a CSS issue in the site. This one doesn't need to go out to npm, so it's fine to cherry pick it after the cut.
I'd like to nominate 603cc48ceba001827d10231d51b4031c7768eef8, as described in this comment: https://github.com/facebook/react-native/commit/603cc48ceba001827d10231d51b4031c7768eef8#commitcomment-23539206
I think this needs to get cherry picked into
0.47.0-stableto fix issues like #15326. Otherwise, multiline autoexpandingTextInputs will always return the sameheightfor their content.
(sorry for the run-around on #15318!)
Most helpful comment
I'd like to nominate
603cc48ceba001827d10231d51b4031c7768eef8, as described in this comment: https://github.com/facebook/react-native/commit/603cc48ceba001827d10231d51b4031c7768eef8#commitcomment-23539206(sorry for the run-around on #15318!)