React-native: [0.42] Commits to cherry pick into stable

Created on 2 Feb 2017  路  11Comments  路  Source: facebook/react-native

Locked

Most helpful comment

@grabbou. Does this commit (#12089 - 031cb20) supposed to be contained in rc.2/3? It will help me a lot! 10x

All 11 comments

I cherry picked and pushed #11676 (Update React versions to non-RC)

https://github.com/facebook/react-native/commit/eb54290a3aa82158b6a735ec2fbd27580d1adec0
https://github.com/facebook/react-native/commit/61848ea2f36a2a9ae254a5ea5a6d2136791eb215
what about those two, right now if I use the Nodes as the UIManager implementation, app crashes on Android when launching with RN0.42RC, but it works great with RN0.41RC

12089 - 031cb2045de0ed430d539eb3d5c44baa2fe3bc8b ?

For the release notes, it might be useful to include https://github.com/facebook/react-native/pull/12089#issuecomment-277553904. Let me know if you need a customised version.

I think that you should highly consider cherry picking alloy's PR into 0.42.
This PR solves a lot of issues to swift-pod based projects.
It is not possible to consume react native from master (because of the lack of android binaries) so the only options are either fork react native (and build android from source) or cherry pick it.
I personally don't like to fork for these reasons and I think the PR implementation is pretty simple and safe to merge

I'll cherry-pick all these today and push a new release candidate today.

Thank you very much!

@grabbou did you get to cherry pick it? I can't find it in 0.42 rc2

@grabbou. Does this commit (#12089 - 031cb20) supposed to be contained in rc.2/3? It will help me a lot! 10x

@guysegal @AleF83 No new RC has been cut yet. @grabbou said he would include all the above commits, so it should all be in the next RC.

@alloy PR was cherry-picked and the build is pending.
@ide PR was also merged.

@grabbou This can be closed.

Was this page helpful?
0 / 5 - 0 ratings