React-native: Changing the bundle ID breaks the upgrader

Created on 19 Dec 2016  路  18Comments  路  Source: facebook/react-native

I've changed the bundle ID of my app to the usual com.something.somethingelse format but because of that react-native-git-upgrade fails. It writes a bunch of files to paths defined using the name in package.json, fails, then resets all the changes.

Is there any way to tell the upgrader what the bundle ID of the apps is supposed to be?

Another problem is that the thing that is supposed to show what part of the upgrade process is broken is apparently broken.

git-upgrade info Commit new version template 
git-upgrade info Generate the patch between the 2 versions 
git-upgrade info Save the patch in temp directory 
git-upgrade info Reset the 2 temporary commits 
git-upgrade info Apply the patch 
fatal: unrecognized input
git-upgrade WARN The upgrade process succeeded but there might be conflicts to be resolved. See above for the list of files that have merge conflicts. 
git-upgrade info Upgrade done 

^^^ Unfortunately, there is no list of files which I'm guessing has something to do with the fatal unrecognized input.

Locked

Most helpful comment

Got the same issue to upgrading from 0.39.2 to 0.40.0

All 18 comments

Got the same issue to upgrading from 0.39.2 to 0.40.0

@g3r4n were you able to fix the issue?

Unrelated to changing bundleID, i get this when upgrading to 0.40

@vinceprofeta I have delete the android and iOS folder. I run react-native init and react-native link to recreate these folder. It fix the issue for me 馃槃

@g3r4n 'not using react-native-git-upgrade' is not a fix. You would lose all manual changes in these folders, the kind of changes that react-native-git-upgrade should help with merging.

And yes, I get the same fatal: unrecognized input error with no extra info (even using --verbose).

I'm getting the same from 0.37.0, any help to get around this one anyone?

I understand people have priorities but the fact that no one involved with the project has replied makes me sad.

I thought the bundle ID had something to do with it because it was creating files in the wrong directory and stuff, but apparently it doesn't work at all for some people. There's a lot about this feature that is ... weird. I don't really understand all what's going on with all the tricky git stuff and I don't have time to look into it. I think it's a cool idea but needs a lot of polishing to get it to work.

I gave up and upgraded manually.

I got the same problem, this worked for me:

Edit ~/.gitconfig and change

[color]
    ui = always

to

[color]
    ui = auto

I figured this out by manually trying to git apply the patch-file in the folder printed at the end of react-native-git-upgrade --verbose (you have to use --verbose for this folder to be printed). This patch-file was color-coded because I had ui = always, and this was the reason git printed fatal: unrecognized input.

I correct the issue by upgrading the tools and RN

@richardkazuomiller, @vinceprofeta @srhise, @MatthiasDebaere, @alnorris Are you still able to reproduce this error using the recent version 0.2.6 of react-native-git-upgrade ?

@ncuillery While I am not one of the previous posters you listed I came here b/c I was experiencing the reported issue with version 0.2.5 of react-native-git-upgrade

git-upgrade info Apply the patch 
fatal: unrecognized input

and was seeking a solution. I have now upgraded to react-native-git-upgrade 0.2.6 and I am still experiencing the same issue.

Getting the same error:

git-upgrade info Commit new version template
[master 1e1ab7b] New version
git-upgrade info Generate the patch between the 2 versions
git-upgrade info Save the patch in temp directory
git-upgrade info Reset the 2 temporary commits
HEAD is now at 8ed1468 Project snapshot
git-upgrade info Apply the patch
error: unrecognized input
git-upgrade WARN The upgrade process succeeded but there might be conflicts to be resolved. See above for the list of files that have merge conflicts.
git-upgrade info Upgrade done
git-upgrade info Temporary working directory: C:\Users\....\AppData\Local\Temp\react-native-git-upgrade

~and it resets to the project snapshot~ it updates and has some files in conflict which I can resolve. Thing is, we have changed a lot of stuff in platform specific project files so I can understand updating RN would be difficult for a tool which checks for manual changes and doesn't want to overwrite them..
(for example: we've created new folders for the iOS xcode project which uses a new name.. not sure if it updated in that folder. I will check when I have more time at hand)

I'm also experiencing this issue with "react-native-git-upgrade": "0.2.7"

I found what was the issue for me. I had updated and installed the new react package I was looking for. I started again from scratch (just making sure that I was using "react-native-git-upgrade": "0.2.7") and it worked nicely.

I run 0.2.7 and got the same error:

npm WARN @shoutem/[email protected] requires a peer of react@^15.0.0 but none was installed.
npm WARN [email protected] requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none was installed.
npm WARN [email protected] requires a peer of react@>=15.1.0 but none was installed.
npm WARN [email protected] requires a peer of react@>= 15.4.1 but none was installed.
npm WARN [email protected] requires a peer of react@>=15.4.0 but none was installed.
npm WARN [email protected] requires a peer of react@^0.13.0 || ^0.14.0 || ^15.0.0 but none was installed.
git-upgrade info Generate new version template
git-upgrade info Add updated files to commit
git-upgrade info Commit new version template
[master 59f8d3c] New version
git-upgrade info Generate the patch between the 2 versions
git-upgrade info Save the patch in temp directory
git-upgrade info Reset the 2 temporary commits
HEAD is now at 923c5bd Project snapshot
git-upgrade info Apply the patch
fatal: unrecognized input
git-upgrade WARN The upgrade process succeeded but there might be conflicts to be resolved. See above for the list of files that have merge conflicts.
git-upgrade info Upgrade done
git-upgrade info Temporary working directory: /var/folders/5k/mywmpyj53gl5qppzytyy43hw0000gn/T/react-native-git-upgrade

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

Still having this issue (or I'm not sure actually if there is error - as I've got error, but at the same time it says it was successful)

git-upgrade info Check for updates
git-upgrade info Using yarn 1.3.2
git-upgrade info Read package.json files
git-upgrade info Check declared version
git-upgrade info Check matching versions
git-upgrade info Check React peer dependency
git-upgrade info Check that Git is installed
git-upgrade info Get information from NPM registry
git-upgrade info Upgrading to React Native 0.53.0, React 16.2.0
git-upgrade info Setup temporary working directory
git-upgrade info Configure Git environment
git-upgrade info Init Git repository
git-upgrade info Add all files to commit
git-upgrade info Commit current project sources
git-upgrade info Create a tag before updating sources
git-upgrade info Generate old version template
git-upgrade info Add updated files to commit
git-upgrade info Commit old version template
git-upgrade info Install the new version
warning " > [email protected]" has incorrect peer dependency "[email protected] || ^0.12.0".
warning " > [email protected]" has incorrect peer dependency "graphql@^0.11.0 || ^0.12.0".
warning " > [email protected]" has incorrect peer dependency "graphql@^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0".
warning " > [email protected]" has unmet peer dependency "[email protected]".
warning " > [email protected]" has unmet peer dependency "babel-core@^6.0.0 || ^7.0.0-0".
git-upgrade info Generate new version template
git-upgrade info Add updated files to commit
git-upgrade info Commit new version template
git-upgrade info Generate the patch between the 2 versions
git-upgrade info Save the patch in temp directory
git-upgrade info Reset the 2 temporary commits
git-upgrade info Apply the patch
error: unrecognized input
git-upgrade WARN The upgrade process succeeded but there might be conflicts to be resolved. See above for the list of files that have merge conflicts.
git-upgrade info Upgrade done

I advise opening a new issue, since this one was closed due to lack of a template + inactivity.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jlongster picture jlongster  路  3Comments

TrakBit picture TrakBit  路  3Comments

despairblue picture despairblue  路  3Comments

janmonschke picture janmonschke  路  3Comments

anchetaWern picture anchetaWern  路  3Comments