React-native: [Packager 0.39] RN Packager doesn't see changes inside node_modules

Created on 5 Dec 2016  路  12Comments  路  Source: facebook/react-native

Description

If I changing a file in my app folder, livereload and HMR works! But LR and HMR doesn't work if I changing a file inside node_modules directory (if stop packager process and start it again, the changes are applying)

With RN 0.38 - 0.38.1 all works fine!

Additional Information

  • React Native version: 0.39
  • Operating System: Mac OS Sierra
  • Watchman: 4.7.0
  • Node: 6.9.1
Locked

Most helpful comment

Looks like the problem is related to jest-haste-map, the whilelist using providesModuleNodeModules (use for _isNodeModulesDir), so it will only process react-native, react-native-windows file changes. (JestHasteMap in node-haste)

It's broken my module development, a temporarily workaround is add the module name to providesModuleNodeModules, or can we provide an option for it?

All 12 comments

I'm experiencing this too after upgrading to RN 0.39.
watchman 4.5.0

We see exactly the same. Things that don't work our end...

  • Manually changing a file in node_modules (I know, I know, very bad!!)
  • npm install
  • npm install -f my_package_name
  • Changing a file in the main repository (which does get its changes reloaded) doesn't trigger the changes in node_modules to be reloaded

This is on Mac OS Sierra. Watchman 4.7.0. Node 6.3.1. React Native 0.39

I'm experiencing this too with RN 0.39

Same issue for me. Has anyone made any progress on this, I ended up rolling back to 0.38

@cpojer Can this regression be introduced by the packager refactoring?

yes, that is most likely the issue.

Looks like the problem is related to jest-haste-map, the whilelist using providesModuleNodeModules (use for _isNodeModulesDir), so it will only process react-native, react-native-windows file changes. (JestHasteMap in node-haste)

It's broken my module development, a temporarily workaround is add the module name to providesModuleNodeModules, or can we provide an option for it?

Any news ? This is a major issue :(

@jhen0409 temporary fix, thanks

@cpojer when's jest latest version going to be out ? I guess once it's out, we will need to wait a newer release of react-native with the latest jest version as its dependency, right ?

soon!

@cpojer Thanks for getting this fixed! Any idea when react native will update to jest-haste-map 19?

Was this page helpful?
0 / 5 - 0 ratings