React-native: Shake to open Dev Menu only work once in 0.36
--- Please use this template, and delete everything above this line before submitting your issue ---
Description
In version 0.36 shake to open dev menu has stopped working as expected. It is possible to open dev menu by shaking device one time but doing it again will not open dev menu.
Reproduction
The problem can easily be reproduced both on ios simulator and ios device. Shake to open dev menu. Cancel (or any other action), shake again to open dev menu does not work. Nothing will happen. To fix the app has to be closed and reopened. On simulator use hardware->shake gesture to simulate same behaviour.
Additional Information
- React Native version: 0.36.0
- Platform: iOS
- Operating System: MacOS
albinhubsch
All 6 comments
Possibly duplicate of https://github.com/facebook/react-native/issues/10485?
bganicky
on 27 Oct 2016
cc @frantic as @bganicky references fd554c31c7bcb2aae5c7d6a64e5bef9bedf56ebb as possibly being related
brentvatne
on 31 Oct 2016
@albinhubsch is it iPad or iPhone? Don't have time to look at this right now, but you can help by reverting https://github.com/facebook/react-native/commit/fd554c31c7bcb2aae5c7d6a64e5bef9bedf56ebb locally and checking if that fixes the issue.
frantic
on 8 Nov 2016
@frantic don't know about iPad, but I experience this on iPhone 6 simulator and iPhone 5c device. I'll try that commit as soon as 0.37 lands.
albinhubsch
on 8 Nov 2016
@frantic @albinhubsch both iPad and iPhone has been affected and it's been already fixed here, but waiting for response from FB member
VojtechBartos
on 10 Nov 2016
@frantic @albinhubsch fix has been merged to master, so i believe it's going to be out with 0.40.0 release
VojtechBartos
on 30 Nov 2016
Related issues
jobsamuel
路
3Comments
janmonschke
路
3Comments
vikeri
路
3Comments
oney
路
3Comments
upbit
路
3Comments
Most helpful comment
@frantic @albinhubsch fix has been merged to master, so i believe it's going to be out with 0.40.0 release