React-native: [RCTImageLoader][0.33 & 0.34] Crash

[pietropizzi]

Issue Description

When scrolling a listview with items that have image views the app will eventually crash in

RCTImageLoader.m#L383 (Crashlytics Crashreport)

or in

RCTImageLoader.m#L502 (Crashlytics Crashreport)

Steps to Reproduce / Code Snippets

In our app just scroll a longer list that has remote images, eventually it will crash.

Expected Results

The app should not crash.

Additional Information

• React Native version: 0.33.0
• Platform: iOS
• Operating System: macOS

[pietropizzi]

This seems to have been introduced in this commit going into RN 0.33: https://github.com/facebook/react-native/commit/14188289fc6254b6704460f7c58e4334f8aa1e25 at least it touches exactly the line that is crashing

[npomfret]

I'm getting lots of crashes also, all related I think:

http://crashes.to/s/96034f860eb
http://crashes.to/s/e5f0b80d061
http://crashes.to/s/40184834c7e

[raspasov]

Hey guys, we have a similar crash, affecting consistently a number of our users - I think related to the problems people have mentioned so far.

http://crashes.to/s/518580ef4b9 (line 383)
http://crashes.to/s/8ebd91bfbf8 (line 385)

Both crashes on React Native 0.33.

[littlesome]

same crash issue
need your help, @javache

[bsiddiqui]

We were able to prevent this crash by prefetching images

[javache]

We have seen these crashes disappear in v34.

[raspasov]

@javache Great! I'll test it out and report back.

[jerson]

Same on 34 RC :(

http://crashes.to/s/7c31b33b411

[pfeiffer]

Seeing this as well - also present in 0.32.

[pietropizzi]

@javache I can confirm the same severity in 0.34 as was in 0.33. In our app you just have to scroll 2 - 3 pages worth and it crashes. Very reproducible.

[chandlervdw]

This has prevented us from upgrading from 0.32. :(

[chiplay]

Same issue here, definitely excited to get this fixed and make the upgrade!

[jerson]

@chiplay for me Strong reference don't solve this problem :/

http://crashes.to/s/c55a4e38ab1

[ide]

Closing this issue since https://github.com/facebook/react-native/issues/9849 is tracking the same bug -- subscribe to that one.