React-native: [0.32.1] Commits to cherry pick into stable release

[grabbou]

[satya164]

FYI we've bunch of regressions in latest release - https://github.com/facebook/react-native/issues?q=is%3Aissue+is%3Aopen+label%3ARegression

[sjmueller]

I haven't seen it mentioned yet, but I'm noticing big problems with image loading and caching in 0.32. In fact it seems like images are not cached at all, resulting in super slow image load times (especially for repeated images like avatars). It prompted me to look through the commit history, and the large image cache refactor could be the culprit: ddc70ff

Should I create a separate issue or is there already something out there covering it?

[bestander]

@sjmueller, please raise a separate issue with a video example if you can and cc people related to the change.
Also cc me, I'll link it internally.

[grabbou]

Nothing explicitly listed so will release w/o cherry-picks.

[bestander]

@grabbou, we want to investigate the image caching issue internally a bit.
Can we delay stable forma day or two?

[grabbou]

It's not yet deployed so it's up to you. Just let me know so I'll update interested ppl via twitter :)

[sjmueller]

Hey all, apologies for the delay regarding image cache / decoding issues. Would you still like me to submit an issue, or did your internal investigation yield the same findings?

[bestander]

Yes Sam, please submit one.
Also if you could help investigating it would be much appreciated

On Tuesday, 23 August 2016, Sam Mueller [email protected] wrote:

Hey all, apologies for the delay regarding image cache / decoding issues.
Would you still like me to submit an issue, or did your internal
investigation yield the same findings?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/9431#issuecomment-241654278,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBdWOmCUzW96uiyufHiW4W25zb8sJ_0ks5qiqajgaJpZM4JlRQa
.

[nihgwu]

@sjmueller I've noticed that issue too, when i preview the loaded image, the image is loaded again, seems the cache doesn't work, I'm using RN0.32RC0

[satya164]

Let's cherry-pick b4999fca0d783bfaeb47200e434760aae8badb14

[mkonicek]

Let's cherry-pick b4999fca0d783bfaeb47200e434760aae8badb14

Yes please. This is the fix for Chrome debugger by @lexs, awesome!

[javache]

Could someone provide some repro instructions for the caching issue? Does this happen on iOS or Android? What are example image URLs that are not cached?

[grabbou]

Also bring back android command commit should be cherry-picked before we ship tomorrow morning.

@javache @bestander @sjmueller shall we move to a separate issue so the cherry-pick thread is not polluted with unrelated comments?

[mkonicek]

shall we move to a separate issue

Yes, is there an issue for the image caching? If not just create one :) https://github.com/facebook/react-native/commit/ddc70ffd85d74592b3be62d37a9ca2de86dbb0ac looks like it might be related, good find @sjmueller! And yeah, we need a repro :) Have more people seen images never being cached? This is only on iOS, correct?

[bestander]

Yes, we should definitely

On Wednesday, 24 August 2016, Mike Grabowski [email protected]
wrote:

Also bring back android command from rnpm - in the morning.

@javache https://github.com/javache @bestander
https://github.com/bestander @sjmueller https://github.com/sjmueller
shall we move to a separate issue so the cherry-pick thread is not polluted
with unrelated comments?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/9431#issuecomment-242144285,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBdWK_Z-Z0dl9wPchY06lh4rmoFkZjbks5qjH7KgaJpZM4JlRQa
.

[rclai]

Question: is this note still in effect (video loading via asset system on iOS)?

[alloy]

If this fix for building a framework version of React Native (with e.g. CocoaPods) gets merged before the release, I’d love to see that go in.

[bestander]

To pick into 0.32.1

• [ ] https://github.com/facebook/react-native/pull/9544 CocoaPods + css-layout
• [ ] https://github.com/facebook/react-native/issues/9581 - image caching bug

[grabbou]

@alloy looks like it's not yet merged, but I'll do as a 0.32.1 as @bestander suggested.

[MajeedThaikas]

I concor

[alloy]

@grabbou This can be closed.