React-native: [0.29] Commits to cherry pick into stable release

Created on 23 Jun 2016  路  11Comments  路  Source: facebook/react-native

Locked

Most helpful comment

I cherry-picked the following commits mentioned in this thread:

  • c57bac4, b4d15d3, 37e41d2 (Navigation patches @jmurzy suggested)
  • a589985 (fix refresh control's visibility)
  • 9845f49 (fix dev mode -- @jsierles does your PR take away extra configuration flexibility? seems like it introduces side effects in a getter method too. if so we should leave the config in the template to provide good defaults while also giving people control)
  • 1a0c69f (React 15.2)
  • 4a15dc814e68 (CocoaPods support for iOS animations)

Sending 0.29.0-rc.2 if CI succeeds.

All 11 comments

a589985b0b417df9a01d5cbdf26b1dc30ca44d53 Fix refresh control with initial refreshing state.

Fix for dev mode being disabled using the new AppDelegate.m: https://github.com/facebook/react-native/commit/9845f49581023302fcb33487bd6df2f7ce8825fa

Also, I think my PR should also go in since the above commit does not actually set defaults for you. It requires you to do it in AppDelegate. I think this will throw people off.

https://github.com/facebook/react-native/pull/8404

1a0c69f4b715df0b5bff041c66f8b27596babf8e: version bump for React

I just picked the log-ios and log-android CLI commands, very useful: https://github.com/facebook/react-native/commit/cf97c9a096d00666b24898aa0ca98ca7f88c8a6b.

Bumped the version to 0.29.0-rc.1 and doing a release. Commits:
https://github.com/facebook/react-native/commits/0.29-stable

I cherry-picked the following commits mentioned in this thread:

  • c57bac4, b4d15d3, 37e41d2 (Navigation patches @jmurzy suggested)
  • a589985 (fix refresh control's visibility)
  • 9845f49 (fix dev mode -- @jsierles does your PR take away extra configuration flexibility? seems like it introduces side effects in a getter method too. if so we should leave the config in the template to provide good defaults while also giving people control)
  • 1a0c69f (React 15.2)
  • 4a15dc814e68 (CocoaPods support for iOS animations)

Sending 0.29.0-rc.2 if CI succeeds.

@ide The PR doesn't take away flexibility, as you can still call any of the methods to update your config. The idea is that defaults should be the _default_. If you don't have the config in the template, the default is to run production mode in development, which is confusing and has happened to a number of people already.

However defaults shouldn't be set in the getter method, rather in the constructor: https://github.com/facebook/react-native/pull/8404#issuecomment-229207463

I cherrypicked 85983d0ae4fac0fc22048bd0d729cdc3ca755d91 to fix #8414

And released 0.29.0-rc.3

I am sending out the stable version right now /doing final tests/ so will close this for now. Thanks everyone, especially @ide, @mkonicek and @bestander for cherry-picking and releasing things!

Was this page helpful?
0 / 5 - 0 ratings