React-native: [0.27] Commits to cherry-pick into stable release

[grabbou]

0.27.0-rc1:

• [x] Use React 15.1.0 and stop using the alpha 7d1b4d681aab9ff1baecc28b57d9299a10e17a7a
• [x] Fix Chrome debugging on Android 24a806a9f106b4d55241c18ac16869240e98b358
• [x] Made npm deployment to be independent of git tags cache 934acd809df9871272731ee70ce6e97e2168f9c1
• [x] Respect original enumerability/writability when polyfilling globals cacf6b1267b9e7bb841d13ce57390ea9edcf29ed

0.27.0-rc2:

• [x] Update node-haste dependency to 2.12.0 (for RN Windows) https://github.com/facebook/react-native/commit/68af89dcbfe96735389bc2909ff10400908a356d

0.27.0-stable

• [x] Fix CocoaPods spec https://github.com/facebook/react-native/commit/3ba232f8fb35c58605ad47d7c25c2d94bc8742a5

Commits cherry-picked so far:
https://github.com/facebook/react-native/commits/0.27-stable

[ide]

Summarizing the discussion about React from https://github.com/facebook/react-native/issues/7385:

• RN currently depends on an alpha release of react
• npm doesn't support prereleases very well
• The React team is aiming to publish a non-prerelease version of react to npm by Monday
• So we'll publish RN 0.27-rc now and mention the prerelease peerDep issue in Known Problems of the release notes
• And when react 15.1.0 is published, we'll update RN's package.json on the 0.27-stable branch and publish 0.27-rc.2

[grabbou]

Thanks @ide for the great summary. I am currently out of the office, but will do the release first thing tomorrow morning (in fact I've already cut it 2 days ago, so just need to update with latest stuff).

[bestander]

https://github.com/facebook/react-native/pull/7619 - makes publishing to npm a bit less flaky

[ide]

https://github.com/facebook/react-native/commit/f7c4ed8926bb883fdb245bd73a77804dd974a14f, which fixes the Chrome debugger needs to be cherry picked.

I also already added a commit to 0.27-stable that makes us use React 15.1.0 instead of the alpha: https://github.com/facebook/react-native/commit/7d1b4d681aab9ff1baecc28b57d9299a10e17a7a

[grabbou]

I've cherry-picked all the mentioned commits + 3d8725dfdbdc1345eb34c409e1a514c845b79dcf to make sure 0.27-rc also works well with Sentry. Doing manual e2e tests to make sure all works fine and sending it to npm.

@ide unfortunately the Chrome debugging still seems to be broken with the same exception, maybe we forgot to update the signature in other places. Anyway - I am shipping it as is to get the React fix and Sentry out faster.

[rozele]

Could we also cherry-pick https://github.com/facebook/react-native/commit/68af89dcbfe96735389bc2909ff10400908a356d? It's another prereq for getting the react-native-windows NPM package out.

cc @mkonicek

[rozele]

@grabbou https://github.com/facebook/react-native/pull/7787, if it's not too late.

[grabbou]

I think we still have some time. I need to test the debugger because from my internal testing it wasn't working despite the fix being landed recently. It could've been my local gradle cache.

[grabbou]

@rozele was the #7787 PR cherry-picking https://github.com/facebook/react-native/commit/68af89dcbfe96735389bc2909ff10400908a356d? If yes, I can just cherry-pick it directly and push to the branch.

[rozele]

@grabbou Yes. That would be great. I don't have push access anyway :-)

[mkonicek]

@grabbou I updated the description to make it easy to keep track of what's been cherry-picked. Reading the comments I can't tell for sure - the comments are more of a discussion.

[satya164]

Just a heads up, we should publish RCs as 0.27.0-rc.1 instead of 0.27.0-rc1 so that NPM picks up the patch releases.

[bestander]

Ah, magic.
I think our npm publish script will work fine with that.
Just need to update docs on the tag format

On Tuesday, 31 May 2016, Satyajit Sahoo [email protected] wrote:

Just a heads up, we should publish RCs as 0.27.0-rc.1 instead of
0.27.0-rc1 so that NPm picks up the patch releases.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/7616#issuecomment-222621662,
or mute the thread
https://github.com/notifications/unsubscribe/ACBdWMcLmT353Gqcqv2gIt2mGAXKiIQDks5qG-74gaJpZM4IhdZq
.

[bestander]

@satya164 , would you send a PR to change the docs?
Considering that you found this out

On Tuesday, 31 May 2016, Satyajit Sahoo [email protected] wrote:

Just a heads up, we should publish RCs as 0.27.0-rc.1 instead of
0.27.0-rc1 so that NPm picks up the patch releases.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/7616#issuecomment-222621662,
or mute the thread
https://github.com/notifications/unsubscribe/ACBdWMcLmT353Gqcqv2gIt2mGAXKiIQDks5qG-74gaJpZM4IhdZq
.

[satya164]

@bestander Sure. Will do in sometime :D

[alloy]

@grabbou This one please 3ba232f8fb35c58605ad47d7c25c2d94bc8742a5 🙏

[grabbou]

Will do :)

[AndrewJack]

Heads up: the 0.27.0-rc2 release hasn't deployed version 0.27.0-rc2 of the Android library, it does have 0.27.0-rc1 and others (see below).

 Directory of /node_modules/react-native/android/com/facebook/react/react-native

05/06/2016  16:43    <DIR>          0.12.0-SNAPSHOT
05/06/2016  16:43    <DIR>          0.23.0-rc3
05/06/2016  16:43    <DIR>          0.23.0-rc4
05/06/2016  16:43    <DIR>          0.24.0-rc1
05/06/2016  16:43    <DIR>          0.27.0-rc1
05/06/2016  16:43               469 maven-metadata.xml
05/06/2016  16:43                32 maven-metadata.xml.md5
05/06/2016  16:43                40 maven-metadata.xml.sha1

[bestander]

Thanks, @AndrewJack. according to CI logs https://circleci.com/gh/facebook/react-native/7116 latest 0.27 release was not done via CI.
Probably was done manually and manual process is prone to errors.
I'll make a 0.27.3 now

[bestander]

I'll give a try to the new version scheme https://github.com/facebook/react-native/blob/master/Releases.md, this patch will be 0.27.0-rc.3

[satya164]

@bestander I think the first RC has to be 0.27.0-rc.0 for this to work.

[bestander]

Oh snap, let me do rc3 then this time

On Sunday, 5 June 2016, Satyajit Sahoo [email protected] wrote:

@bestander https://github.com/bestander I think the first RC has to be
0.27.0-rc.0 for this to work.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/7616#issuecomment-223825009,
or mute the thread
https://github.com/notifications/unsubscribe/ACBdWL0zEx5MkRedq34s02wqju3OBf2Qks5qIwSRgaJpZM4IhdZq
.

[grabbou]

@bestander on a side note - I am doing the branch cut / stable in the morning.

@satya164 does that mean we should send 0.28.0-rc.0 tomorrow? (or just rc without a number)

[bestander]

yep, 0.27.0-rc3 is out

On Sun, Jun 5, 2016 at 11:55 PM, Mike Grabowski [email protected]
wrote:

@bestander https://github.com/bestander have you done that yet? If not

• you can probably leave it till tomorrow as I am doing the stable / beta
  cut in the morning.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/7616#issuecomment-223842887,
or mute the thread
https://github.com/notifications/unsubscribe/ACBdWCpU2z7rreWYCpA45TjJ6AhIZxaAks5qI1P2gaJpZM4IhdZq
.

[satya164]

@grabbou Yup, with 0.28.0-rc.0. The .0 is important :D