React-native: [Android WebView] No Fullscreen API Support

[sdca]

YouTube embeds never show a fullscreen button, and buttons on this test page fail:

http://pearce.org.nz/fullscreen/

[facebook-github-bot]

Hey sdca, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

• If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
• If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
• We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

[avishayil]

+1 on this.

[Frulko]

+1

[Frulko]

Any answers ?

[TeodorKolev]

Is that a joke?

[stereodenis]

is this PR about issue? https://github.com/facebook/react-native/pull/6880

[satya164]

@stereodenis Nope. That PR was filed long after this issue was posted. If anyone has experience with WebView, and can send a PR to fix this, please do. A quick google search gives this - http://stackoverflow.com/questions/15768837/playing-html5-video-on-fullscreen-in-android-webview

[wcastand]

Hi,
i did some digging and found out that we 'only' need to implement two functions to provide the fullscreen on Android since the WebChromeClient is already implemented in the PR posted earlier #6880

From the android documentation, link :

Full screen support
In order to support full screen — for video or other HTML content — 

you need to set a WebChromeClient and implement both 
onShowCustomView(View, WebChromeClient.CustomViewCallback)
and onHideCustomView(). 

If the implementation of either of these two methods is missing
then the web contents will not be allowed to enter full screen. 

Optionally you can implement getVideoLoadingProgressView() to customize
the View displayed whilst a video is loading.

I'm not a Java developper at all so i don't really know how to do this.

[satya164]

PRs are welcome for this.

[mangogogos]

Has anyone been working on this? Would love to have fullscreen support for videos playing in an Android WebView

[T-Spoon]

Submitted a PR for this: https://github.com/facebook/react-native/pull/10327

Getting some eyes on it would be good!

[DeanMW]

@T-Spoon please see #10327

[hramos]

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

• Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
• If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
• Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

[Robo-Rin]

@hramos Can we please re-open this? Having the same issue in 0.49.3.

[hramos]

@Hauuguu can you open a new issue and fill out the entire template?

You can also take a look at #10327 which attempts to fix this, but was closed due to lack of followup.