React-native-windows: Template gitignore file should exclude binlogs

[NickGerleman]

We started dropping binlog files in the project root directory during build. These aren't included in the default gitignore and will be checked in by default.

[gat786]

Hey can I take this issue and work on fixing it?

[acoates-ms]

Go for it.

[gat786]

Hey @acoates-ms can you guide me through what must be done here?
From what I understand the problem is just I need to remove the .binlog files from .gitignore file.

[acoates-ms]

No you need to add the binlog files to the git ignore file that is created during react-native-windows-init.
I believe this file https://github.com/microsoft/react-native-windows/blob/master/vnext/template/_gitignore

[gat786]

was that it?

[NickGerleman]

I think that gitignore file might be for the windows directory instead of the root directory where we currently place the binlog (though I think the windows directory might be a better home for it).

If you wanted to validate, the steps would be:

1. Use the documentation in our Github Wiki on how to test the CLI to make a new RNW app with your changes
2. Init a new git repo in the created directory
3. Do a build with run-windows
4. Confirm Git doesn't try to add binlogs

[gat786]

I tried building it with the changes I made. but it seems it still drops .binlog files in and isn't ignored by the .gitignore files

[goatandsheep]

@gat786 I had the same issue using Visual Studio. I'm not sure why

[gat786]

Well I think this needs to be fixed on the react native template gitignore sides of things rather than rnw template gitignore. I will check if that's the case and leave an update.