React-native-windows: Support react-native-video on RNW vNext

Created on 28 Feb 2019  路  13Comments  路  Source: microsoft/react-native-windows

@harinikmsft Here's the issue

I want to start experimenting with video support in a React Native Windows project.
To stream play all of the content I'm interested in the video player would need to support mpeg dash and Microsoft smooth streaming.

There is an existing project that adds support for video to the C# React Native Windows implementation. I'm not sure if it makes more sense to update the existing react-native-video to work with RNWCPP or if it should live in this repo. Just wanted to point out that it exists :)

Extensions Education ISV must-have needs PM design

Most helpful comment

Latest rnwcpp-preview has initial support for adding custom view managers, more work to do things nicely but its possible now.

All 13 comments

I would recommend that we fork react-native-video and use this work item as an opportunity to flesh out the native component extensions model.

Latest rnwcpp-preview has initial support for adding custom view managers, more work to do things nicely but its possible now.

Excellent!
So with the latest changes I should be able to just add a custom ViewManager for Video and map it to MediaPlayerElement? (for example)

I believe that should be possible but I haven't actually confirmed I can use the custom viewmanager headers/types from outside the repo, we'll be trying that soon in our codebase and fixing up if there are any minor issues. Look at CustomViewManager and replace winrt::checkbox with the xaml control you are wrapping

This should cover adding support to a community module

Removing ready to dev until we have the proper model for native modules.

Moving back to M3 as we'll want to use this as a test case for view managers.

Camera has view manager coverage, so this can move to M4.

@ddalp do you have a topic branch you can share? I'm looking into the versioning story and would like to see a working viewmanager.

I am looking to incorporate a video player in my app. So far linking react-native-video still generates an error. Does anyone know how to embed and play a video with the current vnext release? Or point me to a sample react native windows app that has video embedded in it? Thanks.

@feechin Our current plan is to release a Video native module soon after MVP release.

React-Native-Video community module for windows Cpp/WinRT is now checked in, remaining issue #4157 (keyboard touch events not firing when in full window mode)will be addressed in RNW.

Providing link to PR to help people looking back over the process of adding Windows support to existing native modules: https://github.com/react-native-community/react-native-video/pull/1893

Was this page helpful?
0 / 5 - 0 ratings

Related issues

abhivijay96 picture abhivijay96  路  42Comments

asklar picture asklar  路  18Comments

KinanKazmi picture KinanKazmi  路  33Comments

harinikmsft picture harinikmsft  路  48Comments

dstampher picture dstampher  路  18Comments