React-native-video: [Android] Update Exoplayer to 2.8.X

Created on 4 Aug 2018  路  3Comments  路  Source: react-native-video/react-native-video

Can we update Exoplayer to use 2.8.X? We currently have a hybrid native/react-native app and would like to use the newest Exoplayer, and the current react-native-video code is not compatible with 2.8.X.

Specifically 2.8.X removed the method "clearSelectionOverrides" in this commit. However, react-native-video calls the method here. There will potentially be other incompatibilities, but this was the exception we ran into first.

Platform

Which player are you experiencing the problem on:

  • Android ExoPlayer

Most helpful comment

I'll do this pretty soon and handle the API changes. There were some outstanding PRs I wanted to get merged first to avoid conflicts, but I think those are in now.

All 3 comments

I'll do this pretty soon and handle the API changes. There were some outstanding PRs I wanted to get merged first to avoid conflicts, but I think those are in now.

Done in #1170. I've handled all text track stuff. I didn't hit any issues with other features not working post upgrade, but testing would be welcome in advance of the release. You can grab the update off the master branch.

Did some minor testing off master and everything looks fine!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rogerkerse picture rogerkerse  路  3Comments

Yarkhan picture Yarkhan  路  3Comments

shahen94 picture shahen94  路  3Comments

zachrnolan picture zachrnolan  路  3Comments

RZulfikri picture RZulfikri  路  3Comments