React-native-track-player: WARN: require cycle

[Tubaleviao]

I'm receiving the following WARN:

[Mon Jul 06 2020 11:23:53.136]  WARN     Require cycle: node_modules/react-native-track-player/lib/trackPlayer.js -> node_modules/react-native-track-player/lib/ProgressComponent.js -> node_modules/react-native-track-player/lib/trackPlayer.js

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.

It's not a bug but it's not cool to have it. I solved it already and it works for me, submitting a pull request shortly.

[curiousdustin]

https://github.com/react-native-kit/react-native-track-player/pull/692

[Tubaleviao]

@curiousdustin the PR #692 is kinda old and it has a conflict... The #990 has no conflicts and I just made it, so it's newer and ready to go, please take a look into it (I haven't changed much).

UPDATE: The PR had a problem with the services, I'm looking how to fix it.

[vincentjames501]

Any update @Tubaleviao? This one would be great to fix!

[michaelvitello]

Hi, as seen above there is also another topic about these cycle issues: https://github.com/react-native-kit/react-native-track-player/issues/1057. Is there any plan on fixing them once and for all? I know it's just warning, but it's better not to have them at all.

[Tubaleviao]

I fixed this issue on the PR #1077 2 months ago~

[michaelvitello]

@Tubaleviao Oh, apologies for not noticing, and thanks for having done this! :)

[Tubaleviao]

No problem, I got pissed off with that warning too 😅

[curiousdustin]

Fix released in 1.2.4