React-native-track-player: Cannot read property 'then' of undefined

Created on 27 Dec 2018  路  6Comments  路  Source: react-native-kit/react-native-track-player

Since I upgraded to 1.0.1 I'm getting this issue.

The stack trace is not very helpful

Any idea?

screenshot_20181227-100522

Bug Javascript
Source
picture rgagnon
👍2

Most helpful comment

@rgagnon My project is also impacted : the registerEventHandler is broken.
I tried to hotfix it to create an async method and it works. This error could have been caught with unit tests or flow/typescript...

picture jpolo on 27 Dec 2018
👍3

All 6 comments

https://github.com/react-native-kit/react-native-track-player/blob/cb4aa8977b48cd8a898cc2c99838cbcedb6b1b4e/lib/index.js#L109

Shouldn't be an async method ?

jpolo picture jpolo on 27 Dec 2018

I tried on my side and it worked.

Thank you

rgagnon picture rgagnon on 27 Dec 2018

@rgagnon My project is also impacted : the registerEventHandler is broken.
I tried to hotfix it to create an async method and it works. This error could have been caught with unit tests or flow/typescript...

jpolo picture jpolo on 27 Dec 2018
👍3

I confirm works after added async

rzakirov picture rzakirov on 28 Dec 2018

I'll release a new version tomorrow with the fix. We should definitely automate tests at some point.

Guichaguri picture Guichaguri on 29 Dec 2018

Released 1.0.2

Guichaguri picture Guichaguri on 29 Dec 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

mnlbox picture mnlbox  路  4Comments
b3rkaydem1r picture b3rkaydem1r  路  3Comments
KalebPortillo picture KalebPortillo  路  4Comments
RiccardoNL picture RiccardoNL  路  3Comments
Sathyanarayan09 picture Sathyanarayan09  路  3Comments