React-native-slider: Add thumbSize as a prop (or even thumbStyle)

Created on 3 Apr 2020  路  16Comments  路  Source: callstack/react-native-slider

Only thumbTintColor offers too little flexibility - thumbSize is needed

The size of the thumb can NOT be controlled without affecting the whole slider. On iOS the thumb is significantly bigger than on Android. Even by adding a thumb image scales different from one platform to another. At this point there is no way to apply a fixed thumb size for consistency over the two platforms.

feature request

Most helpful comment

The lack of traction on this issue is surprising to me; This seems critical for anyone who intends to use this slider across multiple platforms and cares for consistency...

All 16 comments

this PR takes care of this for the web implementation if it gets merged. There would be only the native implementation to be done.

I added thumbSize, trackHeight and thumbStyle props

By the way, there could be a quick fix for this: the web implementation should be working perfectly fine for native too, so we could just use the web implementation as the universal implementation. What do you think @michalchudziak ? Of course we would need to ensure that no feature provided by the current native implementation is missing. But is this a path that would be acceptable?

@michalchudziak? Your opinion about it?

+1

Curious where this stands for mobile - would be a helpful feature. Thanks for your contributions toward it!

Actually I'm working on a fully compatible RN + RNWeb version with all the pending feature request I found here. I'm just having some trouble finding some time these 2 weeks to conclude it but you can give it a try. It is npm i -S @sharcoux/slider
If you encounter any trouble you can tell me. It will make me save time when I'm finishing it.

+1

The lack of traction on this issue is surprising to me; This seems critical for anyone who intends to use this slider across multiple platforms and cares for consistency...

Could you give a try at @sharcoux/slider?

+1

Please we need a fix thumb value for android and ios

+1

+1

@raphaelrupprecht @arthur-vargas @ShivamJoker if you need something for now, just try @sharcoux/slider from npm. It is open source and used and maintained by my company. You can ask if you have issues.

In addition to thumbsize support another deal breaker is the ghastly box shadow thats on the thumb handle by default. There should be a way to remove that or just support style prop and call it a day!

+1

Was this page helpful?
0 / 5 - 0 ratings

Related issues

EJohnF picture EJohnF  路  8Comments

pdandradeb picture pdandradeb  路  5Comments

JustynaKK picture JustynaKK  路  8Comments

Vednus picture Vednus  路  9Comments

HITESH122 picture HITESH122  路  8Comments