React-native-share: onClose - Possible Unhandled Promise Rejection

[andyfen]

2016-08-01 11:09:59.584 [warn][tid:com.facebook.react.JavaScript] Possible Unhandled Promise Rejection (id: 3):

getting this error on pressing close running the example

[IsTheJack]

I was getting this error too:

[markgoodyear]

I'm getting this also.

[markgoodyear]

@andyfenelon, @IsTheJack, Actually, this is solved by just adding in a catch. If a user doesn't share, it throws an error of Object {error: "User did not share"} — which will be unhandled without a catch.

So to prevent the warning you can do:

Share.open({
  // share config here
})
.catch(err => console.log(err));

[ncuillery]

I don't really like this workaround. IMO the module shouldn't reject the promise in this case because it's not an "error scenario". Can anybody reopen the issue ?

At least, the rejected value must allow distinction between this case and real errors (creating a UserCancelError should do the job).

According to the JS coding conventions, a promise should reject a instance of Error (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/reject#Description), not an object containing a key named error

I'd remove the use of Exception that is not standard in JavaScript: https://github.com/EstebanFuentealba/react-native-share/blob/master/index.js#L71 (or maybe it's a Windows thing ?)

Are you guys open to a PR ?