React-native-screens: Why is `containedModal` not exported?

Created on 17 Feb 2020  路  5Comments  路  Source: software-mansion/react-native-screens

Why is that stackPresentation not exported/exposed? The index.d.ts doesn't have it, yet when I use it in a project it works great.

native-stack
Source
picture pvinis

Most helpful comment

I think this is just an oversight as we only check TS definition file every once in a while. Happy to accept a PR for the definition file that'd add that.

picture kmagiera on 17 Feb 2020
👍2

All 5 comments

I think this is just an oversight as we only check TS definition file every once in a while. Happy to accept a PR for the definition file that'd add that.

kmagiera picture kmagiera on 17 Feb 2020
👍2

Started it on https://github.com/software-mansion/react-native-screens/pull/355

pvinis picture pvinis on 22 Feb 2020

@pvinis you need help on this?

Hirbod picture Hirbod on 23 Apr 2020

I don't have time to continue this unfortunately :(. Feel free to take over that PR.

pvinis picture pvinis on 20 May 2020

I see that no one has currently time to update the PR and make it compatible with the newest changes to the structure, so I made it: #551.
Thanks for your contribution @pvinis!

WoLewicki picture WoLewicki on 30 Jun 2020
❤1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

beetlebum picture beetlebum  路  5Comments
chengsokdara picture chengsokdara  路  3Comments
harrisrobin picture harrisrobin  路  3Comments
iDuuck picture iDuuck  路  5Comments
ukasiu picture ukasiu  路  4Comments