React-native-router-flux: hideTabBar not working in nested scenes

Created on 26 Sep 2018  路  13Comments  路  Source: aksonov/react-native-router-flux

Version 4.0.3

Tell us which versions you are using:

  • react-native-router-flux v4.0.3
  • react v16.4.2
  • react-native v0.55.4

Expected behaviour

hideTabBar should hide the tab bar in scenes.

Actual behaviour

hideTabBar doesn't hide the tab bar.

Steps to reproduce

For non-obvious bugs, please fork this component, modify Example project to reproduce your issue and include link here.

  1. Create
  2. Inside Stack create
  3. Inside Tabs create
  4. Inside Stack create

Reproducible Demo

<Stack key="root">
  <Stack key="Test" type={ActionConst.RESET} title="Test" hideNavBar>
    <Tabs key="TestTabs" title="TestTabs">
      <Stack key="TestTab" icon={TestIcon}>
        <Scene key="TestScene" component={TestComponent} initial />
        <Scene key="TestScene2" component={TestComponent2} hideTabBar={true} />
      </Stack>
    </Tabs>
  </Stack>
</Stack>

I have seen that there is a closed issue on this topic but it didn't help, and 4.0.2 changelog included this as fixed bug. That is why I opened another issue mentioning v4.0.3
And in the API documentation the has no hideTabBar prop.

bug

Most helpful comment

I am also having this issue. I was previously on 4.0.0-beta.28 which used React Navigation 1.5 and worked fine. I am now trying to upgrade to 4.0.5 to support iPhone XS Max etc.

I'm not sure why there is a closed issue on this - it's definitely a bug.

All 13 comments

I am also having this issue. I was previously on 4.0.0-beta.28 which used React Navigation 1.5 and worked fine. I am now trying to upgrade to 4.0.5 to support iPhone XS Max etc.

I'm not sure why there is a closed issue on this - it's definitely a bug.

I have the same issue.hideTabBar doesn't work in nested stack scenes.

@daviscabral Could you look?

Sure.

I'm not sure why there is a closed issue on this - it's definitely a bug.

If that's not working in the current version - we are going to look into - but v3 and beta versions are not supported (that is stated in the README, issue template and in several other issues already opened). Sorry if that was not clear. I am looking into that now.

We're having this issue on Android as well (ref ios label).

@forsen thank you

@forsen Confirm that hideTabBar inStack is worked, but it still not worked in Scene Props.

@blackbing Please check latest 4.0.6

@aksonov checked lastest 4.0.6, but it still not worked in Scene Props.

@aksonov checked lastest 4.0.6, but it not worked in Scene Props.

Try this, not work.

Actions.jump(SceneKey.SomeScreen, {
          title: name,
        });
````

But try this, it works. 

ActionsSceneKey.SomeScreen
```

Hope can provide same useful infomation.

I find that, when we change screen the way just like jump, push, replace, RNRF could not pass the scene param in to function, so jump function can't get the param like hideTabBar, so the feature could not work.

@MarsLuo Any update on this issue? Is it still true that you can't pass props into jump()?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rafaelcorreiapoli picture rafaelcorreiapoli  路  3Comments

GCour picture GCour  路  3Comments

willmcclellan picture willmcclellan  路  3Comments

vinayr picture vinayr  路  3Comments

basdvries picture basdvries  路  3Comments