React-native-router-flux: Proposal: RNRF 4.0.0-beta.32 as a new package

Created on 25 Aug 2018  路  10Comments  路  Source: aksonov/react-native-router-flux

A lot of issues are coming from the major upgrade of react-navigation from 1.5.6 to 2.x.

That is really making the work of handling issues and fixing bugs a lot more complicated that used to be.

So just to be clear:

What I am proposing here is to branch-out from 4.0.0-beta.31 as v3.1 and keep the warning telling that it is not supported.

So we can keep with the [email protected] and its problems with react-navigation@2 to be fixed as expected.

discussion help wanted question

All 10 comments

Due to critical bugs in 4.0.1, I'm still in 4.0.0-beta.31. I think 4.0.0 is not stabilized yet. I agree with @daviscabral

@mswokk I believe 4.0.1 is stable - but it's not working as before for a lot of cases that I believe were not the main intent of the lib.

But for having a 3.5 version, someone from the community also will have to step up to maintain it. That's the main purpose of this issue too. My focus is on bringing back things that people are missing from v3 on v4.

@daviscabral Sounds good (v3.5)

Cool. I'll fork the last beta using [email protected] to a branch v3.5 and update the package.json to reflect it.

@aksonov that's done - could you publish it as a version please? I've already built and tagged it too over there. And also, ignore the 4.0.2 commit on packages.json in the history - that was really precipitated - but if would be good to release it now that we have a few fixes in place. Thanks.

Ouch - now that I noticed that v3 was already on 3.39.x - probably worth to keep going on there. @aksonov how do you want to proceed?

Ugh, right, v3.5 doesn't look good idea now for me - it could confuse v3 users... What about leaving it as beta (as is now) - as I understand there are no requirements for v4.beta and prod v4 to have the same API/behavior.

We can add 'beta is not supported' note too

Agree. I just had the idea of moving it to its own package - like react-native-router-flux-deprecated. But right after changing the title I was not so sure about it. Anyway, let's focus in the v4 :-)

A note for anyone that end in this thread - there is a branch for beta - and PRs are welcome. I am not interested in working on that version (too much context to load everytime I have to switch between the different versions of react-navigation).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

maphongba008 picture maphongba008  路  3Comments

VictorK1902 picture VictorK1902  路  3Comments

sylvainbaronnet picture sylvainbaronnet  路  3Comments

wootwoot1234 picture wootwoot1234  路  3Comments

sarovin picture sarovin  路  3Comments