React-native-router-flux: Update react-navigation dependency to release version
Is there a reason that the project is depending on React Navigation 1.0.0-beta22? This is 16 releases behind the current version of React Navigation which is now on v1.0.3 and out of the beta/rc stage.
I assume it's due to compatibility issues, have these been identified? I think it would be a good idea to start of list of these kinds of issues so that they can be addressed. Presumably now that react navigation is out of beta there will be less compatibility issues moving forward if we're able to get caught up.
kylethebaker
All 12 comments
I have posted the same issue here https://github.com/aksonov/react-native-router-flux/issues/2865
i think that is more important to have compatibility with previous versions, i mean, RNRF beta 24 is using the last react-navigation, and RNRF beta 28 is using 10.0.0-beta22
marcosmartinez7
on 20 Feb 2018
Unfortunately newer react navigation versions completely change outer state integration stuff: https://reactnavigation.org/docs/redux-integration.html
PR is welcome but I doubt we can avoid any breaking changes to support newer react navigation version...
aksonov
on 22 Feb 2018
There are more breaking changes coming:
https://github.com/react-navigation/react-navigation/pull/3392
aksonov
on 23 Feb 2018
Yeah I've had a ton of issues with everything after 22, I even had to back up my react-native lib to keep everything working right
asciifaceman
on 26 Feb 2018
react navigation is preparing v2, do u guys have a plan to keep supporting the RN changes?
can u guys post some guidance in order to help with that?
marcosmartinez7
on 15 Mar 2018
@marcosmartinez7 I'm working on new RNRF version that will work with v2 views. For v1, I will try to adopt current RNRF by adding empty addListener (if it would work).
aksonov
on 15 Mar 2018
Great! let us know if we can colaborate in something in particular.
marcosmartinez7
on 16 Mar 2018
It would be great if you could make RNRF work with v1. I can't add where I have to add 'addListener'
aksonov
on 16 Mar 2018
I think if we compiled a list of the necessary changes it would make it
easier to collaborate. I guess a good place to start would be to bump the
version of the dependency and see what breaks?
On Mar 16, 2018 5:00 AM, "Pavel Aksonov" notifications@github.com wrote:
It would be great if you could make RNRF work with v1. I can't add where I
have to add 'addListener'—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aksonov/react-native-router-flux/issues/2893#issuecomment-373646949,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEtO_HHx_JheG2PZFPltrBxEeGOy4_UDks5te39KgaJpZM4SLI3U
.
kylethebaker
on 17 Mar 2018
Ok, please check latest master and beta.30. Current error is following (Example project) - addListener is missed:
P.S. I've added addListener to navigationStore but it seems not to be enough...
aksonov
on 17 Mar 2018
I'll play around with the current master this week and see if I can make any progress, I will use the example projects as a base and then when we start making progress I will try the latest version on my ongoing application.
kylethebaker
on 20 Mar 2018
RNRF 4.0.0-beta.40 uses latest react-navigation now (2.x)
aksonov
on 8 Aug 2018
Related issues
basdvries
·
3Comments
VictorK1902
·
3Comments
rafaelcorreiapoli
·
3Comments
willmcclellan
·
3Comments
YouYII
·
3Comments
Most helpful comment
@marcosmartinez7 I'm working on new RNRF version that will work with v2 views. For v1, I will try to adopt current RNRF by adding empty addListener (if it would work).