React-native-router-flux: Scenes inside tabs (switch) getting corrently unmounted and then incorrectly re-mounted

Created on 15 May 2017  Â·  10Comments  Â·  Source: aksonov/react-native-router-flux

Version

Tell us which versions you are using:

  • react-native-router-flux v3.39.1
  • react-native v0.44

This is a clone of #1329. I am opening a new issue since I cannot reopen #1329. All relevant history is there.

Most helpful comment

i had to downgrade router-flux for now. my deps:
"react": "16.0.0-alpha.3",
"react-native": "0.43.3",
"react-native-router-flux": "3.37.0".
works for me

All 10 comments

can confirm it. all scenes do re rendering while clicking between tabs.
added: working this way without or with "Switch"

Can you test this PR? => #1386

I did. It did not help. I essentially used your fork of the repo. I still see the issue.

This is happening to us as well

(Also, this didn't start happening until we upgraded from React Native 0.42 to 0.44)

That's interesting. Did you do this comparison with the same version of react-native-router-flux?

Get Outlook for iOShttps://aka.ms/o0ukef


From: Luke Miles notifications@github.com
Sent: Tuesday, May 16, 2017 5:02:48 PM
To: aksonov/react-native-router-flux
Cc: Ujwal Setlur; Author
Subject: Re: [aksonov/react-native-router-flux] Scenes inside tabs (switch) getting corrently unmounted and then incorrectly re-mounted (#1870)

(Also, this didn't start happening until we upgraded from React Native 0.42 to 0.44)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/aksonov/react-native-router-flux/issues/1870#issuecomment-301947902, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFkMXSc4c5q-TKjwV7uJ93zhEPiSpdR0ks5r6jkogaJpZM4NboZ4.

i had to downgrade router-flux for now. my deps:
"react": "16.0.0-alpha.3",
"react-native": "0.43.3",
"react-native-router-flux": "3.37.0".
works for me

Thanks, downgrade to 3.37.0 resolve the issue.

@sarovin

thanks, I've tested your PR, and it fix the problem.

@ezha86 - confirmed that works. 0.43.3 comes with react 16.0.0-alpha.6 -- important to note because you have to downgrade to -alpha.3 for this to work. Definitely not psyched about downgrading react...

Was this page helpful?
0 / 5 - 0 ratings

Related issues

YouYII picture YouYII  Â·  3Comments

fgrs picture fgrs  Â·  3Comments

tonypeng picture tonypeng  Â·  3Comments

GCour picture GCour  Â·  3Comments

willmcclellan picture willmcclellan  Â·  3Comments