React-native-router-flux: React native 27 is out 3 hours ago. Any plans for 3.27.0?

Created on 6 Jun 2016  路  14Comments  路  Source: aksonov/react-native-router-flux

Most helpful comment

Which as I'm sure we're all aware is my birthday. 馃帀

All 14 comments

According to RN release notes there are lot's of changes related to navigation, including breaking

Breaking changes related to Navigation

  • Kill NavigationLegacyNavigator (ef44781) - @hedgerwang
  • Kill NavigationExperimental Containers (14eb427) - @ericvicenti
  • Kill NavigationView (c3714d7) - @hedgerwang

New features

  • Animated: Implement toJSON method of Animated (17f0807) - @wusuopu
  • Expose a new prop transition for scene renderer. (55c3086) - @hedgerwang

Bug Fixes

  • Fix propType check for NavigationCard. (b1cd1cb) - @hedgerwang
  • NavigationExperimental: didFocus event should fired after transition finishes. (8975bb8) - @hedgerwang
  • Fix a bug where NavigationPropTypes.SceneRenderer was a plain object (0e997c6) - @joenoon

IOS specific

  • NavigatorIOS: Expose interactivePopGestureEnabled property (4d2c72b) - @rigdern

+1

Has anyone had a chance to test this yet? Let's use this issue to collect bugs (if any).

As stated in release notes _NavigationRootContainer_ is removed. Assuming that, RNRF is completely broken, since _Scene_ makes use of _NavigationRootContainer_. Or am I wrong?

@Andreyco RNRF is locked to 0.26.x, so RNRF should be perfectly fine. I'm sure there will be a lot of work to make RNRF work with 0.27.x given some of the changes upstream. So RNRF will hold people back to 0.26.x for now. I will try to allocate some time this week to look at the 0.27.x path.

@joenoon oops, it sounded differently as I mentioned that. RNRF works just great as is, with RN 0.26. I meant it's not in shape ready for RN 0.27, which has introduced several breaking changes.

Maybe worth testing with the release candidate of 0.28 - which has just been labeled. This is due to be final on June 20th

Which as I'm sure we're all aware is my birthday. 馃帀

Looks like no sense to work on 0.27, because 0.28 breaks things again, please check my latest post for #557

@aksonov Agreed. And 0.28 will add important fixes like this one: https://github.com/ericvicenti/navigation-rfc/issues/61

@aksonov agreed. I've spent a few hours reading v0.27 and v0.28 navigator code. There are several breaking changes related to the same components. Makes no sense to invest time for two consecutive breaking changes that are only a few weeks apart. Also v0.28 it's already in RC so we can already start coding for it.

Okey, 3.30.0 version doesn't depend from 0.26 anymore (i've forked NavigationExperimental API to separate package). We will update fork (react-native-experimental-navigation) when new changes within Experimental Navigation API will be made (we could clone even latest master fixes now!). Also we will update this component to work with latest version API but it is not so critical now (now component still depends from 0.26 API, but not from React Native 0.26)

Feedback is welcome.

@joenoon and others, if you want to adopt RNRF to latest 0.28 (or even master) API, let me know. I've published latest master as react-native-experimental-navigation, 0.29.0-alpha, so you could play it with RNRF right now.

Closing it for now. If someone wish to upgrade RNRF to latest API, let me know, PR is welcome.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

GCour picture GCour  路  3Comments

wootwoot1234 picture wootwoot1234  路  3Comments

kirankalyan5 picture kirankalyan5  路  3Comments

maphongba008 picture maphongba008  路  3Comments

xnog picture xnog  路  3Comments