React-native-router-flux: Contributors wanted!

[aksonov]

I want to make my and your development easier with this component, but i can't spend much time on it. I do my best to make the component better and more robust, thanks for everybody for created issues, it is very valuable!

Unfortunately, number of PRs is minimal, even more, some guys just silently clone the component (even not fork), add some improvements and start promoting it as own one even without preserving copyright (however thanks for mention me as person who "inspire" them ;). I believe it is wrong way for open source development, we need to unite all our efforts to create something really great.

If somebody wants to do many changes (fix issues, write docs/unit tests) without waiting me to accept it, i'm ready to add him as collaborator.

[zebulgar]

I'd be interested! I'm not sure how much time I can dedicate as well but since we're using this library in our production app I will probably be motivated to fix issues that arise

[chetstone]

I was thinking about trying to help with documentation. There's still an awful lot I don't understand about this component, but perhaps I could take a stab at rewriting the readme and you could review it.

[aksonov]

@MITDelian you are welcome (added)

[aksonov]

@chetstone You are welcome, help with documentation is really necessary. Btw, I've added you as collaborator as well.

[zebulgar]

@aksonov I thought it might be helpful to have a chat room. I've seen gitter.im used often so I set one up. just might chat some things as I'm learning the component: https://gitter.im/aksonov/react-native-router-flux

[chetstone]

@MITDelian Thanks for the chatroom. See you there.
@aksonov Thanks. But I'll want you to review docs carefully please before pushing.

[zebulgar]

@chetstone happy to help review as well. I'll spend some time this weekend really trying to understand the component. One of my major goals is to make integration with a pre-existing redux store much easier

[markburns]

Happy to help out. Just picking up a project again that uses this, and found some incompatibility with the latest react-native. Thought I'd browse the issues to see if it's reported and found this issue. Even better if I can just fix it as soon as I understand the problem.

[thachp]

@aksonov - I will be happy to help out.

[aksonov]

@thachp @markburns thanks for help. Please check latest issues and try to create PR for them.

[smallsaucepan]

Hi @aksonov. I wouldn't mind taking a look at #62 if you still want some help.

[aksonov]

@smallsaucepan Yes, please.

[mmazzarolo]

Hi @aksonov, I'm using react-native-router-flux in production and I would like to help when possible.

[aksonov]

@mmazzarolo You are welcome to help with README as well as other open issues.

[aksonov]

176 maybe is first priority for now, then #187

[lynndylanhurley]

Hi @aksonov - I'm sure you've seen it already, but I just pushed a fix for #176.

[aksonov]

Who want to help and have time, please check https://github.com/aksonov/react-native-router-flux/issues/307

[aksonov]

FYI. Collaborators are still wanted (who could regularly answer/resolve issues, propose PRs, review my changes, etc.).

[gustavovnicius]

@aksonov, I'll be looking at #370. It's being a real pain for me. Do you have some idea that might help?

[charpeni]

@aksonov I'd be interested in helping you as collaborator by managing issues, propose and review pull requests, documentation and unit tests as well.

FYI, I'm one of the contributors of react-native-simple-router which is a simple and basic integration of the Navigation API.

[aksonov]

@charpeni You are welcome! Please check all issues marked with 'help wanted' and submit PR for any.

[markburns]

I think everyone here (including me) was confusing collaborators/contributors. It seems @aksonov is just asking for help but is not asking about adding people as collaborators.

BTW, you might want to follow the model of trusting/adding people based on their contributions here or elsewhere.

E.g. Rubinius is contributor-friendly:
http://www.programblings.com/2008/04/15/rubinius-for-the-layman-part-2-how-rubinius-is-friendly/

It can be rewarding to be listed as a collaborator on a project and the trust can inspire people to contribute even more than the initial contribution.

[aksonov]

Actually I really want to add active collaborators as contributors. However so far I see situation when people want to become contributors initially, without any experience with PRs.

Pavel.

16 апр. 2016 г., в 03:58, Mark Burns [email protected] написал(а):

I think everyone here (including me) was confusing collaborators/contributors. It seems @aksonov is just asking for help but is not asking about adding people as collaborators.

BTW, you might want to follow the model of trusting/adding people based on their contributions here or elsewhere.

E.g. Rubinius is contributor-friendly:
http://www.programblings.com/2008/04/15/rubinius-for-the-layman-part-2-how-rubinius-is-friendly/

It can be rewarding to be listed as a collaborator on a project and the trust can inspire people to contribute even more than the initial contribution.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[aksonov]

@cridenour , @lynndylanhurley, @joenoon Would you like to be collaborators for this project?

[aksonov]

@lelandrichardson are you interesting to be collaborator?

[joenoon]

@aksonov sure, thanks. i'm using this project quite a bit so i hope to keep contributing regularly.

[aksonov]

@philipshurpik Philip, are you still using the component and want to be a collaborator?

[philipshurpik]

@aksonov yes, we use it in new version of our app )
Would be nice to be a collaborator

[aksonov]

@jeroenbourgois Thanks for help with README. Are you using the component in real app and want to be a collaborator?

[jeroenbourgois]

@aksonov I am using it to create a real production app. I would be happy to contribute, but I do have to say this is my very first React Native project alltogether so I have a lot of learning to do.

[aksonov]

@jeroenbourgois Sure, you may focus on answering issues, README improving, etc. Unfortunately a lot of duplicates are created nowadays.. And any PR should be reviewed anyway.

[aksonov]

Guys, please check any new created issues and feel free to submit answer or fix it. Please add proper label and assign it to yourself to avoid any duplicate work. Thanks.

[cridenour]

@aksonov I would love to. Thanks!

[lelandrichardson]

@aksonov Airbnb is going to be using this library in production, so I would definitely be interested in being a contributor.

Thanks for your great work so far!

[lynndylanhurley]

@aksonov - sure! I think this project would benefit from a test suite - would you like me to start with that?

[aksonov]

@lynndylanhurley Sure, it would be great!

[aksonov]

all contributors, please PM me if you need WebStorm license, i've just got open source license.

[aksonov]

Guys, a lot of issues (mostly quite stupid) were created recently. Feel free to help if you can, unfortunately i have quite limited time now.

[AlexDM0]

I'd be up for helping out. I've been using this project a lot in our own app and we'll be working with it for some time to come. I can't promise I'll be able to help out with issues but I can submit pull reqs for any issues that I may encounter in our own project.

We've recently been trying to involve the community in one of our projects vis.js and I know how difficult it is to try to make something community supported, so best of luck!

[sibelius]

@aksonov I'm willing to help on triage of issues and review of PR

[aksonov]

@sibelius Thanks, I've sent you invitation! Feel free to review existing issues/PRs.

[aksonov]

up, very actual now.

[aksonov]

v4 beta based on React Navigation is ready (#1974), looking contributors for v4 now (@sibelius, @cridenour @AlexDM0, @jeroenbourgois, @joenoon, @philipshurpik @chetstone, @charpeni are you still using RNRF ?)

[AlexDM0]

I am, Yes. I was thinking of making my own lib based on react navigation. I'll be happy to address issues that I run across but I'm not sure of the process. There are some annoyances I had with the current architecture so I'm not sure any fix would fit the philosophy of this project.

Main issue I had was that the topbar was only configurable on the router. Not in the scene itself. Left button, right button etc.

On 7 Jul 2017, at 19:11, Pavel Aksonov [e-mail] wrote:

v4 beta based on React Navigation is ready (#1974), looking contributors for v4 now (@sibelius, @cridenour @AlexDM0, @jeroenbourgois, @joenoon, @philipshurpik @chetstone are you still using RNRF ?)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[aksonov]

@AlexDM0 Strange, v3 allowed you to define left, right, title as static properties for your components. v4 should support it as well (because React Navigation supports it)

[AlexDM0]

Is that in the documentation somewhere? The props on the API docs seem to have to be supplied as scene props. From the component in the scene I'd like to change those properties because they are depending on the context of the component itself.

On 7 Jul 2017, at 19:28, Pavel Aksonov [e-mail] wrote:

@AlexDM0 Strange, v3 allowed you to define left, right, title as static properties for your components. v4 should support it as well (because React Navigation supports it)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[aksonov]

Yes, v3 doesn't provide access to properties.
v4 provides the same access to navigation state as React Navigation:
https://reactnavigation.org/docs/intro/headers

[charpeni]

@aksonov Yes :)

[joenoon]

@aksonov neat about v4! I switched to plain react-navigation in April. It was not the easiest switch, but it worked out. I'll probably just stay with that for now unless I have time for another refactor.

[AlexDM0]

Currently I use the navbar from rnrf in simple views. For Views that have a more complex use (dynamic titles, context aware buttons etc) I have my own topbar implementation. Since I'm building the app for our company I can allocate time to implement v4 but I don't have much time for issues and the like. As I said, the ones I run into I'd be willing to fix. The move to v4 won't be done until it is out of beta though.

Cheers

On 7 Jul 2017, at 21:14, Joe Noon [e-mail] wrote:

@aksonov neat about v4! I switched to plain react-navigation in April. It was not the easiest switch, but it worked out. I'll probably just stay with that for now unless I have time for another refactor.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[aksonov]

Who could help with Android support?

[daisydon]

Do we currently support image as navigation title? If not, I am thinking to contribute on that enhancement.

[aksonov]

@daisydon No, it is not supported yet, PR is welcome (as titleImage prop)

[AlexDM0]

Wouldn't it make more sense to just allow a custom element instead of differentiating between images or text? I can imagine svg, small styled views etc.

On 20 Jul 2017, at 09:23, Pavel Aksonov [e-mail] wrote:

@daisydon No, it is not supported yet, PR is welcome (as titleImage prop)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[aksonov]

@AlexDM0 It is supported already - renderTitle

[rajsuvariya]

@aksonov I am interested. But as I don't have too much experience in this technology, so I would like to start with small tasks. Please let me know if there are any.
Thanks

[aksonov]

@rajsuvariya Thanks! The most wanted task now is prepare some MobX demo with authentication, but you can start from smaller tasks like answering questions here and submit PR to solve the issues.

[rajsuvariya]

I am trying to change some code for my application. I am trying to change it inside myproject's /node_modules/react-native-router-flux/src/Router.js. But the same is not being reflected in the app. Then I tried to add just log inside App component like following, but even that is not working.

  componentDidMount() {
    console.log('dsasd');
    BackHandler.addEventListener('hardwareBackPress', this.onBackPress);
  }

Then I completely removed the code of Router.js then also the app is working fine. How can I change the code inside node_module/router_flux and make it work in my application?

[aksonov]

@rajsuvariya Change RNRF package.json to point to src/index.js and restart packager.

[aksonov]

I've just marked all tasks anybody could help with PR as 'help wanted'

[mcabs3]

@aksonov I don't know if I need to be a contributor, but I would love to try and help people with documentation issues and/or usability issues. Let me know what I can do and if I need a role. I will continue to try to get docs up to date as well and eventually can help with some PRs.

Cheers

[aksonov]

@mcabs3 Thank you for your help. If you want you can also check tickets with 'help needed' tag

[VahidBo]

@aksonov I'm using react-native-router-flux in my projects so I like to help as much as i can.

[mcabs3]

@aksonov can you add me as a collaborator please?

[aksonov]

@mcabs3 Done. Feel free to close issues - most issues nowadays are questions... Maybe we have to redirect them to stackoverflow.

[onrige]

@aksonov Hey. I am also interested in help if you still need it. I am already done some PRs and try to help people with issues in free time but it would be great if you will add me as a collaborator.

[daviscabral]

If needed - I would like to help too - mainly keeping v3 and helping people around it - not sure if is something that you still wish - but since I see a lot of folks still using it, at least maintenance for a few basic issues would be nice while a major upgrade can't be done in most of the projects. Thoughts?

[aksonov]

@onrige Thanks! Just sent you the invitation.

[aksonov]

@daviscabral Could you show me your PRs first? v3 support would be great!

[daviscabral]

@aksonov sure - no worries. Just opened #2532 with a few changes related to react 16.0.0.

[mvanroon]

Count me in!

I believe one important thing to be done is manage the questions being asked here in github in the form of issues. They should be asked on gitter or stackoverflow. Maybe we could also add gh-pages and add some more examples and common problems/faq there? I’d be more than happy to help you out there

[aksonov]

Please do, it would great to manage questions

28 окт. 2017 г., в 15:26, Michiel van Roon [e-mail] написал(а):

Count me in!

I believe one important thing to be done is manage the questions being asked here in github in the form of issues. They should be asked on gitter or stackoverflow. Maybe we could also add gh-pages and add some more examples and common problems/faq there? I’d be more than happy to help you out there

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[aksonov]

Dear maintainers and supporters, I have vacation until the end of August. You are welcome to answer issues, submit/review/merge PRs, etc.

[daviscabral]

Thank you and have a great time!

[aksonov]

If someone still wants to help, he can choose "help wanted" tag and work. Also I can pay for some issues from my opencollective budget.

[darrencruse]

I noticed the issue about the current RNRF not being up to date with the latest react-navigation v3, as well as this issue about needing contributors, and I also noticed react-navigation issues about needing contributors, and also wanting to add a simpler api.

My question: has there ever been talk of teaming up and merging the two libraries?

[aksonov]

@darrencruse I talked with some guys from react-navigation team two years ago. They don't want to use JSX as route declaration like RNRF does. However we also discussed possible splitting react-navigation into many modules (separate for router, separate for tabs, etc.), so RNRF could be implemented as router for react-navigation v3 now

[aksonov]

Help with RNRF v5 is needed:
https://github.com/aksonov/react-native-router-flux/issues/3655