React-native-reanimated-bottom-sheet: Re-render breaks onOpenEnd and onCloseStart

[adoniscoder]

Hi, I have callbacks for onOpenEnd and onCloseStart that will cause to state change on the parent component but the problem is after the first call these two methods will not be called anymore, if I remove the setState it will work as normal.

[stachu2k]

I have the same issue. For me onOpenStart nad onOpenEnd events are not always firing after upgrade to react-native 0.61.5 and react-native-navigation: 3.7.0. I have the latest 1.0.0-alpha.19 version of bottom sheet.

[wassgha]

Same here.

[stachu2k]

Any news?

[adoniscoder]

if you pass all the events to the bottomsheet it works well although it isn't a clean approach but for now it fixes the problem.
<BottomSheet ref={this.bs} initialSnap={1} enabledBottomInitialAnimation onOpenStart={(): void => {}} onOpenEnd={this.sheetOpenEnd} onCloseStart={this.sheetCloseStart} onCloseEnd={(): void => {}} callbackNode={this.fall} snapPoints={this.snapPoints} renderContent={(): React.ReactNode => this.props.children} renderHeader={this.renderHeader} />

[stachu2k]

@adoniscoder Sadly, it doesn't work for me :(

[karimcambridge]

onCloseEnd really needs a fix, especially on iOS #136 . @osdnk

[yzalvov]

@stachu2k, if it's still relevant try using the patched version I posted in #136 . It puts all my open/close events in order. The code is also available via this gist ReanimatedBottomSheet_patched.js.

[karimcambridge]

@stachu2k, if it's still relevant try using the patched version I posted in #136 . It puts all my open/close events in order. The code is also available via this gist ReanimatedBottomSheet_patched.js.

Can you create a pull request?

-- edit --

The patch works perfect!

[yzalvov]

@karimcambridge I’m glad it helps.

As for the pull request, I assume that usually PR is a fix or an addition to the original code. I can see the part of the original code for the event handlers and would love to PR a fix, but as I said before I’m not sure I’d be able to make enough time at the moment for digging into it so that other things won’t be broken.

Also I use hooks which, as I guess, is not what the original code is based on. Another complication.

So a small nice and clean patch wrapper looks like a way to go.

[yzalvov]

@karimcambridge , @osdnk I think for the fix it's safe to use Animated conditions from the patch I posted. I guess this part may be tricky so the sketch I helped myself with may be useful.

[mayconmesquita]

@yzalvov using the patch solved the issue here! Thanks!