React-native-paper: List.Item height
Environment
Latest stable version of paper.
Description
Based on Material Design specs list item height must be:
- With title: 48px
- With title and icon: 56px
- With title and description: 72px
https://material.io/design/components/lists.html#specs
But now List.Item component height are:
- With title: 54px
- With title and icon: 72px
- With title and description: 72px
Reproducible Demo
<List.Item
title="Trello"
left={props => <List.Icon icon="folder" />}
description="Project 1, Project 2"
/>
<List.Item
title="Trello"
left={props => <List.Icon icon="folder" />}
/>
<List.Item
title="Trello"
/>
agat
All 9 comments
Yes, List.Item lacks some variants.
ocarreterom
on 12 Mar 2019
@agat wanna make a PR?
ferrannp
on 14 Mar 2019
If no one working on this issue, I would like to work on it.
Taym95
on 14 Mar 2019
There is a desire to try to do it, but there is no time in the coming days.
agat
on 14 Mar 2019
@Taym95 Fell free to submit PR :)
Trancever
on 14 Mar 2019
@Taym95 Have you had a chance to take a stab at this?
smkhalsa
on 4 Apr 2019
I would like to give a shot on this issue too!
Can somebody quickly tell me how I can test the component after making changes?
mitulsavani
on 4 Apr 2019
@mitulsavani There is an Example app in Example directory. For more informations check Contributing Guide
Trancever
on 4 Apr 2019
Fix is included into 3.0.0-alpha.0.
Trancever
on 15 Apr 2019
Related issues
sritharanpalani
路
4Comments
ZhengYuTay
路
3Comments
zachariahtimothy
路
3Comments
satya164
路
4Comments
mihaidaviddev
路
3Comments
Most helpful comment
If no one working on this issue, I would like to work on it.