React-native-orientation: Update to react-native 0.40.0

Created on 5 Jan 2017  路  6Comments  路  Source: yamill/react-native-orientation

Please can you update to new react-native version?
https://github.com/facebook/react-native/releases/tag/v0.40.0

Most helpful comment

I am getting the following file not found error on RN 0.40.0:

screen shot 2017-01-09 at 12 13 05 pm

All 6 comments

I am getting the following file not found error on RN 0.40.0:

screen shot 2017-01-09 at 12 13 05 pm

I know this isn't really a good long term solution, and I don't know enough about the react build processes to do it right, but if anyone else is running into this problem and wants a quick fix, you can just remove the include line and replace it with this:

@interface Orientation : NSObject <RCTBridgeModule>
+ (void)setOrientation: (UIInterfaceOrientationMask)orientation;
+ (UIInterfaceOrientationMask)getOrientation;
@end

I believe the fix for this is a simple two line alteration in the import statements, as contained in this pull request:

https://github.com/yamill/react-native-orientation/pull/146/commits/6ee0ddb90ffb4fab4f09180330ee22edb28c1bad

This is following Facebook's direction in how to update third party modules for react native 40.0.

@yamill can I do something help you land one of these PRs?

5a16ac8a3f96e12969d86a1dd1f6d548efc213b2 was merged. Should resolve RN 0.40 + issues.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

44326334 picture 44326334  路  8Comments

wellyshen picture wellyshen  路  3Comments

testxin picture testxin  路  4Comments

abartolo picture abartolo  路  6Comments

DriesVS picture DriesVS  路  7Comments