React-native-orientation: Orientation lockToLandscape() defaults to landscape but allows back to portrait

[larryranches]

The Orientation Method lockToLandscape() method is defaulting the view to landscape but doesn't actually lock landscape or disable portrait. If I flip the orientation back to portrait, it allows it to switch back to portrait.

I would think that it would actually lock the view to landscape it will disable all other orientations. Does this library support this? Am I missing something?

Any help would much appreciated!

[larryranches]

@yamill any ideas on this?

[ardalann]

Related #136

[lavarajallu]

Hello @larryranches just you have to try this:
in AppDelegate.m adding both two lines

#import "../../node_modules/react-native-orientation/iOS/RCTOrientation/Orientation.h"

 - (UIInterfaceOrientationMask)application:(UIApplication *)application supportedInterfaceOrientationsForWindow:(UIWindow *)window {
    return [Orientation getOrientation];
  }

[GeoffreyPlitt]

@lavarajallu Is there a more general react-native-ish approach for this? Rather then deep editing of node-modules?

[soutot]

@lavarajallu I tried this but still not working. Any suggestions?

Here's my AppDelegate.m:

#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>
#import <React/RCTRootView.h>

#import "../../node_modules/react-native-orientation/iOS/RCTOrientation/Orientation.h"

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  NSURL *jsCodeLocation;

  jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index.ios" fallbackResource:nil];

  RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
                                                      moduleName:@"teste"
                                               initialProperties:nil
                                                   launchOptions:launchOptions];
  rootView.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];

  self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
  UIViewController *rootViewController = [UIViewController new];
  rootViewController.view = rootView;
  self.window.rootViewController = rootViewController;
  [self.window makeKeyAndVisible];
  return YES;

   - (UIInterfaceOrientationMask)application:(UIApplication *)application supportedInterfaceOrientationsForWindow:(UIWindow *)window {
    return [Orientation getOrientation];
}

@end

also tried #import "Orientation.h"

[anthonyjoeseph]

This works for me:

#import "AppDelegate.h"

#import "Orientation.h"

#import <React/RCTBundleURLProvider.h>
#import <React/RCTRootView.h>

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  NSURL *jsCodeLocation;

  jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index.ios" fallbackResource:nil];

  RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
                                                      moduleName:@"Broccoli"
                                               initialProperties:nil
                                                   launchOptions:launchOptions];
  rootView.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];

  self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
  UIViewController *rootViewController = [UIViewController new];
  rootViewController.view = rootView;
  self.window.rootViewController = rootViewController;
  [self.window makeKeyAndVisible];
  return YES;
}

- (UIInterfaceOrientationMask)application:(UIApplication *)application supportedInterfaceOrientationsForWindow:(UIWindow *)window {
  return [Orientation getOrientation];
}

@end

[soutot]

I posted a solution here https://github.com/yamill/react-native-orientation/issues/136#issuecomment-290476178

Also created a repo with a working example: https://github.com/soutot/react-native-orientation-test

Hope it helps

[lavarajallu]

But where it i can placed

On Aug 17, 2017 11:04 PM, "Tiago Souto" [e-mail] wrote:

I posted a solution here #136 (comment)
https://github.com/yamill/react-native-orientation/issues/136#issuecomment-290476178

Also created a repo with a working example: https://github.com/soutot/
react-native-orientation-test

Hope it helps

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yamill/react-native-orientation/issues/121#issuecomment-323141277,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnAEmhD9imaWMQVtSI5RyGreMeUA7ks5sZHj0gaJpZM4LC3tY
.

[soutot]

@lavarajallu in my case I had to replace the import in my node_modules/react-native-orientation/iOS/Orientation.h to look like this: #import <React/RCTBridgeModule.h>

Let me know if it helps

[lavarajallu]

Okay thanq

On Aug 17, 2017 11:54 PM, "Tiago Souto" [e-mail] wrote:

@lavarajallu https://github.com/lavarajallu in my case I had to replace
the import in my node_modules/react-native-orientation/iOS/Orientation.h
to look like this: #import

Let me know if it helps

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yamill/react-native-orientation/issues/121#issuecomment-323154721,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnC1dV_bV6AP9YanGgGN3FG3Si23Oks5sZIVPgaJpZM4LC3tY
.

[lavarajallu]

mr@GeoffreyPlitt you have to go in header search path in
$(SRCROOT)/../node_modules/react-native-orientation/iOS/RCTOrientation in recursive method go to settings

[wookelvin]

@soutot This work around fixed my issue on iOS.
See the sample of code here for the snippets of code to implement:
https://github.com/soutot/react-native-orientation-test/blob/master/ios/teste/AppDelegate.m

[callmejm]

@wookelvin does it miss a } ? code is inside - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { or outside ?

[dantranv]

I have the same issue.
@JayricMok it should be after close } because the method is returned YES so it wont execute the code.