React-native-navigation: Command event callback not being invoked on popping

[mrousavy]

🐛 Bug Report

  useNavigationCommand(
    useCallback(() => {
      console.debug(`${componentId} on navigation command!`);
      canNavigate.current = false;
    }, [componentId])
  );
  useNavigationCommandComplete(
    useCallback(() => {
      console.debug(`${componentId} on navigation command complete!`);
      canNavigate.current = true;
    }, [componentId])
  );

this uses the react-native-navigation-hooks package

Per docs, this command should be called on every command:

The commandListener is called whenever a _Navigation command_ (i.e push, pop, showModal etc) is invoked.

In my case, when pushing from Screen A to Screen B, the order of execution is the following:

1. ✅ First callback is invoked
2. ✅ Navigation animation happens
3. ✅ Second callback is invoked

When popping from Screen B to Screen A though;

1. ✅ First callback is invoked
2. ✅ Navigation animation happens
3. ❌ nothing

Have you read the Contributing Guidelines on issues?

Yes.

Platform

• [x] iOS
• [ ] Android (not yet tested!)

[guyca]

@mrousavy Are you listening to these commands in screen B?

[mrousavy]

@guyca I have listeners on both screens, none of them trigger on pop. 😟

[guyca]

@mrousavy I'm unable to reproduce in the Playground app. Please repro as this could be an issue with the hooks library or a timing issue related to component unmount.

[mrousavy]

did you try it on iOS? I'll try creating a quick repro later

[guyca]

Yup, tried on iOS and a global command listener.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

[stale[bot]]

The issue has been closed for inactivity.